netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Jakub Kicinski <kuba@kernel.org>,  <netdev@vger.kernel.org>,
	<linux-wireless@vger.kernel.org>
Subject: Re: pull-request: wireless-next-2024-01-25
Date: Fri, 26 Jan 2024 12:05:17 +0200	[thread overview]
Message-ID: <877cjwz9ya.fsf@kernel.org> (raw)
In-Reply-To: <18d447cc0b8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (Arend Van Spriel's message of "Fri, 26 Jan 2024 07:37:23 +0100")

Arend Van Spriel <arend.vanspriel@broadcom.com> writes:

> On January 26, 2024 7:01:18 AM Kalle Valo <kvalo@kernel.org> wrote:
>
>> Jakub Kicinski <kuba@kernel.org> writes:
>>
>>> On Thu, 25 Jan 2024 10:40:30 +0000 (UTC) Kalle Valo wrote:
>>>> The first "new features" pull request for v6.9. We have only driver
>>>> changes this time and most of them are for Realtek drivers. Really
>>>> nice to see activity in Broadcom drivers again.
>>>
>>> minor thing for a follow up:
>>>
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c:432:49:
>>> warning: no newline at end of file
>>
>> Oh, sorry about that. Any tips how to detect this?
>
> I thought checkpatch would signal that or is it a sparse warning.

I don't run checkpatch except for ath10k/ath11k/ath12k, too much noise.
I ended up adding this to my script:

for file in $(git ls-tree -r --name-only HEAD drivers/net/wireless/ net/wireless/ net/mac80211/); do if [ "$(tail -c 1 $file | cat -E)" != "$" ]; then echo $file: no newline at end of file; fi; done

> Anyway, I can fix it.

Thanks!

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-01-26 10:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 10:40 pull-request: wireless-next-2024-01-25 Kalle Valo
2024-01-26  0:51 ` Jakub Kicinski
2024-01-26  6:01   ` Kalle Valo
2024-01-26  6:37     ` Arend Van Spriel
2024-01-26 10:05       ` Kalle Valo [this message]
2024-01-26 18:52         ` Jakub Kicinski
2024-01-27 10:08           ` Kalle Valo
2024-01-29 19:55             ` Jakub Kicinski
2024-02-13 15:27               ` Kalle Valo
2024-01-26  1:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cjwz9ya.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=arend.vanspriel@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).