* [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit()
@ 2022-11-17 3:56 Zhang Changzhong
2022-11-17 10:09 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2022-11-17 3:56 UTC (permalink / raw)
To: Ajay Singh, Claudiu Beznea, Kalle Valo, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Johnny Kim,
Greg Kroah-Hartman, Chris Park, Rachel Kim, Nicolas Ferre
Cc: Zhang Changzhong, linux-wireless, netdev, linux-kernel
The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
dev_kfree_skb() to fix it.
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/wireless/microchip/wilc1000/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
index 9b319a4..6f3ae0d 100644
--- a/drivers/net/wireless/microchip/wilc1000/netdev.c
+++ b/drivers/net/wireless/microchip/wilc1000/netdev.c
@@ -730,6 +730,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev)
if (skb->dev != ndev) {
netdev_err(ndev, "Packet not destined to this device\n");
+ dev_kfree_skb(skb);
return NETDEV_TX_OK;
}
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit()
2022-11-17 3:56 [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit() Zhang Changzhong
@ 2022-11-17 10:09 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-11-17 10:09 UTC (permalink / raw)
To: Zhang Changzhong
Cc: Ajay Singh, Claudiu Beznea, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Johnny Kim, Greg Kroah-Hartman,
Chris Park, Rachel Kim, Nicolas Ferre, linux-wireless, netdev,
linux-kernel
Zhang Changzhong <zhangchangzhong@huawei.com> writes:
> The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
> dev_kfree_skb() to fix it.
>
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Same as in your other patch, have you tested this is on a real device?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-17 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 3:56 [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit() Zhang Changzhong
2022-11-17 10:09 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).