From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465A0C433F5 for ; Tue, 14 Dec 2021 15:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235404AbhLNPqj (ORCPT ); Tue, 14 Dec 2021 10:46:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234610AbhLNPqj (ORCPT ); Tue, 14 Dec 2021 10:46:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 216C6C061574; Tue, 14 Dec 2021 07:46:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B5EB9615A0; Tue, 14 Dec 2021 15:46:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C84FC34606; Tue, 14 Dec 2021 15:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639496798; bh=lpMJyBaryDhU6pdFEk23SJlqLoV1mD69gh70IqL8reE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ruvvT96NLYiBGRmzeo6xh7E28uyoreQQvj/Z2GhwLnGcaUERCJuq7NdKw5qo4g/rY MpRaakxm3iRBkfb04Psdeui91kK7BAgLsZd+uUtja6HVHDqv4Aan6I3e1rROmXRLMZ w9g2scAyGEpu2X7NLKHdzfb4b5bwt6tLOGH4P6buaidGL/YSatjfZ5TQMKn5OGLO+X ka53aY+PbWRCFuYikHRVp+CqbsRJbIVzrEzwL+zkl6wMeV0aoRj4p45+2+oPKbeVRo RAPGspKzXPkIelQm5L+a7G1KEzxXxKckTHYw5CVtZ9n3lA1ABKbO6l20p4VO9CBOaj 37vHLyPDq5fKw== From: Kalle Valo To: Kees Cook Cc: linux-hardening@vger.kernel.org, "David S. Miller" , Jakub Kicinski , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/17] ath11k: Use memset_startat() for clearing queue descriptors References: <20211213223331.135412-1-keescook@chromium.org> <20211213223331.135412-9-keescook@chromium.org> <87v8zriv1c.fsf@codeaurora.org> Date: Tue, 14 Dec 2021 17:46:31 +0200 In-Reply-To: <87v8zriv1c.fsf@codeaurora.org> (Kalle Valo's message of "Tue, 14 Dec 2021 08:02:07 +0200") Message-ID: <877dc7i3zc.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Kalle Valo writes: > Kees Cook writes: > >> In preparation for FORTIFY_SOURCE performing compile-time and run-time >> field bounds checking for memset(), avoid intentionally writing across >> neighboring fields. >> >> Use memset_startat() so memset() doesn't get confused about writing >> beyond the destination member that is intended to be the starting point >> of zeroing through the end of the struct. Additionally split up a later >> field-spanning memset() so that memset() can reason about the size. >> >> Cc: Kalle Valo >> Cc: "David S. Miller" >> Cc: Jakub Kicinski >> Cc: ath11k@lists.infradead.org >> Cc: linux-wireless@vger.kernel.org >> Cc: netdev@vger.kernel.org >> Signed-off-by: Kees Cook > > What's the plan for this patch? I would like to take this via my ath > tree to avoid conflicts. Actually this has been already applied: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=d5549e9a6b86 Why are you submitting the same patch twice? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches