From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E7BC433DB for ; Fri, 29 Jan 2021 21:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FEA664E0A for ; Fri, 29 Jan 2021 21:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233214AbhA2VCw (ORCPT ); Fri, 29 Jan 2021 16:02:52 -0500 Received: from mga17.intel.com ([192.55.52.151]:51137 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233058AbhA2VCt (ORCPT ); Fri, 29 Jan 2021 16:02:49 -0500 IronPort-SDR: 8KblLcceztZkYaPwKrtUs3MHaRKVSg7Zpa4Bdu31wt16ydqP5vFqWUwYsJ4sydo0/mAOXH81Za cKGH237Us7IA== X-IronPort-AV: E=McAfee;i="6000,8403,9879"; a="160254863" X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; d="scan'208";a="160254863" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 13:02:07 -0800 IronPort-SDR: WRXbI5a0a2lSURK7Xr+Kb73RU8Knx2kYK8+5YKwRrDalQfM+N1tz56QvtjlLDZxPBLbsnQF1Zr wiJYNCMM+VoA== X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; d="scan'208";a="389456096" Received: from ndatiri-mobl.amr.corp.intel.com (HELO vcostago-mobl2.amr.corp.intel.com) ([10.212.145.249]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 13:02:06 -0800 From: Vinicius Costa Gomes To: Vladimir Oltean Cc: "netdev@vger.kernel.org" , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "jiri@resnulli.us" , "kuba@kernel.org" , "Jose.Abreu@synopsys.com" , Po Liu , "intel-wired-lan@lists.osuosl.org" , "anthony.l.nguyen@intel.com" , "mkubecek@suse.cz" Subject: Re: [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles In-Reply-To: <20210126000228.gpyh3rrp662wysit@skbuf> References: <20210122224453.4161729-1-vinicius.gomes@intel.com> <20210122224453.4161729-6-vinicius.gomes@intel.com> <20210126000228.gpyh3rrp662wysit@skbuf> Date: Fri, 29 Jan 2021 13:01:53 -0800 Message-ID: <877dnvtq2m.fsf@vcostago-mobl2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Vladimir Oltean writes: > On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote: >> Avoid possible TX Hangs caused by using long Qbv cycles. In some >> cases, using long cycles (more than 1 second) can cause transmissions >> to be blocked for that time. As the TX Hang timeout is close to 1 >> second, we may need to reduce the cycle time to something more >> reasonable: the value chosen is 1ms. >> >> Signed-off-by: Vinicius Costa Gomes >> --- > > Don't you want this patch to go to 'net' and be backported? Will propose this patch to 'net'. Thanks. Cheers, -- Vinicius