From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA43CC433E2 for ; Fri, 11 Sep 2020 17:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1F2D221EB for ; Fri, 11 Sep 2020 17:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbgIKRoC (ORCPT ); Fri, 11 Sep 2020 13:44:02 -0400 Received: from mga14.intel.com ([192.55.52.115]:60320 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgIKRnx (ORCPT ); Fri, 11 Sep 2020 13:43:53 -0400 IronPort-SDR: DB3U5EjSV4GfQ3I8/Ny1loerOHjpD9f99Wt904IzecaSFPwoM8FWIjNuB4JBqmofGCezGF7S2a wMzZB4KAxuOg== X-IronPort-AV: E=McAfee;i="6000,8403,9741"; a="158105557" X-IronPort-AV: E=Sophos;i="5.76,416,1592895600"; d="scan'208";a="158105557" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 10:43:49 -0700 IronPort-SDR: T6pL/wuj80l8d4SrfF4sts8AKUxwgNl50UXbdaKj6UC7II/4IK+FzYgIxsUc0RzhIhOjch0ytr +rR9yL0NnYMQ== X-IronPort-AV: E=Sophos;i="5.76,416,1592895600"; d="scan'208";a="481403148" Received: from prbhatt-mobl1.amr.corp.intel.com (HELO ellie) ([10.212.20.132]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 10:43:48 -0700 From: Vinicius Costa Gomes To: Jesse Brandeburg , netdev@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org Subject: Re: [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly In-Reply-To: <20200911012337.14015-6-jesse.brandeburg@intel.com> References: <20200911012337.14015-1-jesse.brandeburg@intel.com> <20200911012337.14015-6-jesse.brandeburg@intel.com> Date: Fri, 11 Sep 2020 10:43:48 -0700 Message-ID: <877dt0nr8r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jesse Brandeburg writes: > This takes care of all of the trivial W=1 fixes in the Intel > Ethernet drivers, which allows developers and maintainers to > build more of the networking tree with more complete warning > checks. > > Almost all of the changes were trivial comment updates on > function headers, but some of the changes were for variables that > were storing a return value from a register read, where the > return value wasn't used. Those conversions to remove the lvalue > of the assignment should be safe because the readl memory mapped > reads are marked volatile and should not be optimized out without > an lvalue (I suspect a very long time ago this wasn't guaranteed > as it is today). > > Inspired by Lee Jones' series of wireless work to do the same. > Compile tested only. > > Signed-off-by: Jesse Brandeburg > --- > drivers/net/ethernet/intel/e100.c | 8 +- > drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++++++---------- > drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +++-- > .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - > drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- > drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++++-- > drivers/net/ethernet/intel/e1000e/phy.c | 3 + > drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- > drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- > drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- > drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + > drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + > drivers/net/ethernet/intel/igb/igb_main.c | 28 ++-- > drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- > drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- > drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++++++-------- > drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- > .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- > 20 files changed, 265 insertions(+), 228 deletions(-) > ... > diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c > index 4e7a0810eaeb..2120dacfd55c 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c > @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) > * at the end of this routine. > */ > ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); > + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); > Adding this debug statement seems unrelated. > /* Disabled the PHY transmitter */ > e1000_write_phy_reg(hw, 0x2F5B, 0x0003); Apart from this, Reviewed-by: Vinicius Costa Gomes -- Vinicius