From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1336BC43603 for ; Fri, 20 Dec 2019 07:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCB5820684 for ; Fri, 20 Dec 2019 07:19:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="LK+J1zGw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727135AbfLTHTm (ORCPT ); Fri, 20 Dec 2019 02:19:42 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:13887 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfLTHTl (ORCPT ); Fri, 20 Dec 2019 02:19:41 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576826381; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=qQnAOBnm851gvtQP9RARiafEiullQAdZpKpw996rOSk=; b=LK+J1zGwcyMsY9map+ofgfL+RI6uZaFvetVaCYLvEDOLJWxeXKpS78fk6PUlYuv7t2Jg/vnI UEVQvDOJDTLdtRObq/UJ8oEjmHp9FwDJlqI3u8W3HNXMvU+7XcLcuV817Y6WrJjFnz5RHnTJ 4SyBsAWj1O3P9t1Tkphn9HJ1caY= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5dfc7608.7fdada0a99d0-smtp-out-n02; Fri, 20 Dec 2019 07:19:36 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 76001C4479C; Fri, 20 Dec 2019 07:19:35 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 04C50C433CB; Fri, 20 Dec 2019 07:19:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 04C50C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Nick Desaulniers Cc: Network Development , linux-wireless@vger.kernel.org, LKML , clang-built-linux , Nathan Chancellor , ath11k@lists.infradead.org Subject: Re: [PATCH] ath11k: Remove unnecessary enum scan_priority References: <20191211192252.35024-1-natechancellor@gmail.com> <87a77o786o.fsf@kamboji.qca.qualcomm.com> Date: Fri, 20 Dec 2019 09:19:30 +0200 In-Reply-To: (Nick Desaulniers's message of "Thu, 19 Dec 2019 09:06:37 -0800") Message-ID: <877e2r4g71.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Nick Desaulniers writes: > On Thu, Dec 19, 2019 at 5:32 AM Kalle Valo wrote: >> >> Nick Desaulniers writes: >> >> > On Wed, Dec 11, 2019 at 11:23 AM Nathan Chancellor >> > wrote: >> >> wmi_scan_priority and scan_priority have the same values but the wmi one >> >> has WMI prefixed to the names. Since that enum is already being used, >> >> get rid of scan_priority and switch its one use to wmi_scan_priority to >> >> fix this warning. >> >> >> > Also, I don't know if the more concisely named enum is preferable? >> >> I didn't get this comment. > > Given two enums with the same values: > enum scan_priority > enum wmi_scan_priority > wouldn't you prefer to type wmi_ a few times less? Doesn't really > matter, but that was the point I was making. Ah, now I got it :) This enum is part of firmware interface (WMI) so yes, I prefer to use the wmi_ prefix to make that obvious. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches