From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings Date: Fri, 05 Oct 2018 14:04:42 +0300 Message-ID: <877eiw1wol.fsf@codeaurora.org> References: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Maya Erez , , , , To: YueHaibing Return-path: In-Reply-To: <1538737646-118337-1-git-send-email-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> (yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org's message of "Fri, 5 Oct 2018 11:07:26 +0000") Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org YueHaibing writes: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Just out of curiosity, what kind of overhead are we talking about here? -- Kalle Valo