From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
network dev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces
Date: Thu, 10 Aug 2017 18:33:51 +0200 [thread overview]
Message-ID: <877eybs7ps.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20170810162722.GH24790@lunn.ch> (Andrew Lunn's message of "Thu, 10 Aug 2017 18:27:22 +0200")
Andrew Lunn <andrew@lunn.ch> writes:
> On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote:
>> Andrew Lunn <andrew@lunn.ch> writes:
>>
>> >> We are - rtnetlink_event() does the job. We, however, don't have a
>> >> special IFLA_EVENT_* for name change and end up with IFLA_EVENT_NONE.
>> >
>> > What is in this event? Old and new name? Just the new name?
>>
>> Basically, it's everything we know about the interface - type, index,
>> name, mtu, qdisc, ... - see rtnl_fill_ifinfo(). Back to your question -
>> it's only the new name.
>
> So the program needs to keep track of ifindex to know which interface
> has changed name. Doable.
>
Yes, and I'd expect that's what these daemons do nowdays to track name
changes for down interfaces (if/when they care).
> I still expect this has the potential to break something. You probably
> should be asking on linux-api for the API experts opinion.
>
Good idea, I'll do RFCv2 submission.
--
Vitaly
next prev parent reply other threads:[~2017-08-10 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 10:42 [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces Vitaly Kuznetsov
2017-08-09 12:29 ` 吉藤英明
2017-08-09 15:05 ` Vitaly Kuznetsov
2017-08-09 16:10 ` Andrew Lunn
2017-08-10 8:41 ` Vitaly Kuznetsov
2017-08-10 9:03 ` Eric Dumazet
2017-08-10 10:01 ` Vitaly Kuznetsov
2017-08-10 14:13 ` Andrew Lunn
2017-08-10 15:24 ` Vitaly Kuznetsov
2017-08-10 16:27 ` Andrew Lunn
2017-08-10 16:33 ` Vitaly Kuznetsov [this message]
2017-08-10 16:48 ` David Miller
2017-08-10 16:55 ` David Ahern
2017-08-10 17:16 ` Stephen Hemminger
2017-08-11 9:01 ` Vitaly Kuznetsov
2017-08-10 14:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eybs7ps.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).