netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew@lunn.ch, jiri@resnulli.us,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 2/2] Revert "net: dsa: Implement ndo_get_phys_port_id"
Date: Tue, 10 Jan 2017 15:44:45 -0500	[thread overview]
Message-ID: <877f623arm.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170110203237.23907-3-f.fainelli@gmail.com>

Hi Florian,

Florian Fainelli <f.fainelli@gmail.com> writes:

> This reverts commit 3a543ef479868e36c95935de320608a7e41466ca ("net: dsa:
> Implement ndo_get_phys_port_id") since it misuses the purpose of
> ndo_get_phys_port_id(). We have ndo_get_phys_port_name() to do the
> correct thing for us now.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Thanks,

        Vivien

  reply	other threads:[~2017-01-10 20:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 20:32 [PATCH net-next 0/2] net: dsa: Implement ndo_get_phys_port_name() Florian Fainelli
2017-01-10 20:32 ` [PATCH net-next 1/2] " Florian Fainelli
2017-01-10 20:44   ` Vivien Didelot
2017-01-10 20:50   ` Andrew Lunn
2017-01-10 20:58     ` Vivien Didelot
2017-01-10 20:58     ` Florian Fainelli
2017-01-11  7:28       ` Jiri Pirko
2017-01-11  7:29   ` Jiri Pirko
2017-01-10 20:32 ` [PATCH net-next 2/2] Revert "net: dsa: Implement ndo_get_phys_port_id" Florian Fainelli
2017-01-10 20:44   ` Vivien Didelot [this message]
2017-01-11  7:29   ` Jiri Pirko
2017-01-11 14:59 ` [PATCH net-next 0/2] net: dsa: Implement ndo_get_phys_port_name() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f623arm.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).