From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@oss.sgi.com
Subject: Re: [RFT] merged 8139too NAPI
Date: Tue, 21 Oct 2003 22:35:11 +0900 [thread overview]
Message-ID: <877k2ysohc.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20031020131106.6862e951.shemminger@osdl.org>
Stephen Hemminger <shemminger@osdl.org> writes:
> + spin_lock_bh(&tp->rx_lock);
> /* disable Tx ASAP, if not already */
> tmp8 = RTL_R8 (ChipCmd);
> if (tmp8 & CmdTxEnb)
> @@ -1679,6 +1682,7 @@
>
> /* ...and finally, reset everything */
> rtl8139_hw_start (dev);
> + spin_unlock_bh(&tp->rx_lock);
->tx_timeout is on timer softirq context. So softirq was disabled already.
Or Is this for future changes?
> + /* Check uncommon events with one test. */
> + if (unlikely(status & (PCIErr | PCSTimeout | RxUnderrun | RxOverflow)))
> + rtl8139_weird_interrupt (dev, tp, ioaddr,
> + status, link_changed);
I couldn't find this on previous email, rtl8139_weird_interrupt was changing.
if (unlikely(status & (PCIErr|PCSTimeout|RxUnderrun|RxErr|RxFIFOOver)))
rtl8139_weird_interrupt(dev, tp, ioaddr, status, link_changed);
It should check the above status.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2003-10-21 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3F9070B6.9090306@pobox.com>
2003-10-18 12:56 ` [Fwd: [RFT] NAPI for 8139too] OGAWA Hirofumi
2003-10-20 15:41 ` Stephen Hemminger
2003-10-20 20:11 ` [RFT] merged 8139too NAPI Stephen Hemminger
2003-10-21 13:35 ` OGAWA Hirofumi [this message]
2003-10-28 19:47 ` [PATCH] Updated 8139too with NAPI Stephen Hemminger
2003-10-29 19:34 ` Jeff Garzik
2003-10-30 17:12 ` OGAWA Hirofumi
[not found] ` <20031030104943.20b61af0.shemminger@osdl.org>
[not found] ` <87ekwu9tn4.fsf@devron.myhome.or.jp>
2003-11-11 22:31 ` Stephen Hemminger
2003-11-12 0:20 ` Jeff Garzik
2003-11-12 15:41 ` OGAWA Hirofumi
2003-11-12 16:01 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877k2ysohc.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).