Netdev List
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "syzbot" <syzbot@kernel.org>
Cc: syzkaller-bugs@googlegroups.com,
	 "Alexander Aring" <alex.aring@gmail.com>,
	 "David S. Miller" <davem@davemloft.net>,
	 "Eric Dumazet" <edumazet@google.com>,
	 "Jakub Kicinski" <kuba@kernel.org>, <linux-wpan@vger.kernel.org>,
	 <netdev@vger.kernel.org>,  "Paolo Abeni" <pabeni@redhat.com>,
	 "Stefan Schmidt" <stefan@datenfreihafen.org>,
	horms@kernel.org,  linux-kernel@vger.kernel.org,
	 syzbot@lists.linux.dev
Subject: Re: [PATCH] ieee802154: fix kernel-infoleak in dgram_recvmsg()
Date: Thu, 28 May 2026 09:45:00 +0200	[thread overview]
Message-ID: <878q94htab.fsf@bootlin.com> (raw)
In-Reply-To: <62795fd9-fc0c-48eb-bb82-05ffc5a57104@mail.kernel.org> (syzbot@kernel.org's message of "Wed, 27 May 2026 20:18:18 +0000 (UTC)")

Hello,

LGTM.

> -	addr->mode = mode;
> -
> -	if (mode == IEEE802154_ADDR_NONE)
> +	if (mode == IEEE802154_ADDR_NONE) {
> +		memset(addr, 0, sizeof(*addr));
> +		addr->mode = IEEE802154_ADDR_NONE;
>  		return 0;
> +	}
> +
> +	addr->mode = mode;
>  
>  	if (!omit_pan) {
>  		memcpy(&addr->pan_id, buf + pos, 2);
>
>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

      reply	other threads:[~2026-05-28  7:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 20:18 [PATCH] ieee802154: fix kernel-infoleak in dgram_recvmsg() syzbot
2026-05-28  7:45 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q94htab.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stefan@datenfreihafen.org \
    --cc=syzbot@kernel.org \
    --cc=syzbot@lists.linux.dev \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox