* [PATCH] Fix le16_to_cpu warning for beacon_interval
@ 2022-04-29 10:20 Srinivasan Raju
2022-04-29 10:25 ` Kalle Valo
2022-04-29 11:16 ` Julian Calaby
0 siblings, 2 replies; 3+ messages in thread
From: Srinivasan Raju @ 2022-04-29 10:20 UTC (permalink / raw)
Cc: Kalle Valo, David S. Miller, edumazet@google.com, Jakub Kicinski,
pabeni@redhat.com, open list:NETWORKING DRIVERS (WIRELESS),
open list:NETWORKING DRIVERS, open list
Fixed the following warning
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
---
drivers/net/wireless/purelifi/plfxlc/chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
index a5ec10b66ed5..5d952ca07195 100644
--- a/drivers/net/wireless/purelifi/plfxlc/chip.c
+++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
@@ -30,10 +30,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
{
if (!interval ||
(chip->beacon_set &&
- le16_to_cpu(chip->beacon_interval) == interval))
+ chip->beacon_interval) == interval)
return 0;
- chip->beacon_interval = cpu_to_le16(interval);
+ chip->beacon_interval = interval;
chip->beacon_set = true;
return plfxlc_usb_wreq(chip->usb.ez_usb,
&chip->beacon_interval,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Fix le16_to_cpu warning for beacon_interval
2022-04-29 10:20 [PATCH] Fix le16_to_cpu warning for beacon_interval Srinivasan Raju
@ 2022-04-29 10:25 ` Kalle Valo
2022-04-29 11:16 ` Julian Calaby
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-04-29 10:25 UTC (permalink / raw)
To: Srinivasan Raju
Cc: David S. Miller, edumazet@google.com, Jakub Kicinski,
pabeni@redhat.com, open list:NETWORKING DRIVERS (WIRELESS),
open list:NETWORKING DRIVERS, open list
Srinivasan Raju <srini.raju@purelifi.com> writes:
> Fixed the following warning
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
The preferred style is this:
Fix the following sparse warnings:
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
> ---
> drivers/net/wireless/purelifi/plfxlc/chip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The subject should be:
[PATCH] plfxlc: fix le16_to_cpu warning for beacon_interval
> diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
> index a5ec10b66ed5..5d952ca07195 100644
> --- a/drivers/net/wireless/purelifi/plfxlc/chip.c
> +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
> @@ -30,10 +30,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
> {
> if (!interval ||
> (chip->beacon_set &&
> - le16_to_cpu(chip->beacon_interval) == interval))
> + chip->beacon_interval) == interval)
> return 0;
I think there's no need to use three lines anymore, two lines should be
enough:
if (!interval ||
(chip->beacon_set && chip->beacon_interval == interval))
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix le16_to_cpu warning for beacon_interval
2022-04-29 10:20 [PATCH] Fix le16_to_cpu warning for beacon_interval Srinivasan Raju
2022-04-29 10:25 ` Kalle Valo
@ 2022-04-29 11:16 ` Julian Calaby
1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2022-04-29 11:16 UTC (permalink / raw)
To: Srinivasan Raju
Cc: Kalle Valo, David S. Miller, edumazet@google.com, Jakub Kicinski,
pabeni@redhat.com, open list:NETWORKING DRIVERS (WIRELESS),
open list:NETWORKING DRIVERS, open list
Hi Srinivasan,
On Fri, Apr 29, 2022 at 8:49 PM Srinivasan Raju <srini.raju@purelifi.com> wrote:
>
> Fixed the following warning
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
> ---
> drivers/net/wireless/purelifi/plfxlc/chip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
> index a5ec10b66ed5..5d952ca07195 100644
> --- a/drivers/net/wireless/purelifi/plfxlc/chip.c
> +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
> @@ -30,10 +30,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
> {
> if (!interval ||
> (chip->beacon_set &&
> - le16_to_cpu(chip->beacon_interval) == interval))
> + chip->beacon_interval) == interval)
Shouldn't that first ")" go at the end of the line?
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-29 11:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-29 10:20 [PATCH] Fix le16_to_cpu warning for beacon_interval Srinivasan Raju
2022-04-29 10:25 ` Kalle Valo
2022-04-29 11:16 ` Julian Calaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).