From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970FCC43217 for ; Mon, 28 Mar 2022 15:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240138AbiC1Prr (ORCPT ); Mon, 28 Mar 2022 11:47:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240012AbiC1Pra (ORCPT ); Mon, 28 Mar 2022 11:47:30 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADEF63516; Mon, 28 Mar 2022 08:45:22 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1648482320; bh=K5yQXy54JHY7rUigzUmzvWRAXrXCNGan+s8kLUY9Ypg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ofDZ73PT3hE1qlcu5lkOC7Sq4XZwM2YVi91N9xPgJ8T28zB6ObXxYQLy2Ib9wAkQh trPseX/HRnwhCB/Q1iSVmHzDZTK7WAMCRs92J9513k/P+D36geZxbHH9PJBz7zBTs5 JAjOeESdMBiptiWXnD/0XBUIBlA3VdGERP/vdGzc0CJKCrOlh+542VIEz934paARwx EH6uMRV1+3zh9ah3wD1fEVbTTXLSOZR/jQ+DwhDCcVATPXrVWRVNItknc6uWynz40Z dHqJem2DBzk1Ogq3y014Ngis6EjOQhHGcwykAzUboE+Bh5qBgXQ5vXwup7Uop5Hun1 hCfHRA5rzU0Ew== To: trix@redhat.com, kvalo@kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: Re: [PATCH v2] ath9k: initialize arrays at compile time In-Reply-To: <20220328130727.3090827-1-trix@redhat.com> References: <20220328130727.3090827-1-trix@redhat.com> Date: Mon, 28 Mar 2022 17:45:19 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <878rsu5be8.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org trix@redhat.com writes: > From: Tom Rix > > Early clearing of arrays with > memset(array, 0, size); > is equivilent to initializing the array in its decl with > array[size] = {}; > > Convert the memsets to initializations. > > Signed-off-by: Tom Rix The changes LGTM. However, the patch doesn't apply cleanly; could you please rebase against the ath-next branch[0] and resubmit? -Toke [0] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=ath-next