From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDA1C4332B for ; Thu, 25 Feb 2021 19:27:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1968164F1A for ; Thu, 25 Feb 2021 19:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234372AbhBYT1K (ORCPT ); Thu, 25 Feb 2021 14:27:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbhBYTZS (ORCPT ); Thu, 25 Feb 2021 14:25:18 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40DE8C06178A for ; Thu, 25 Feb 2021 11:24:33 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id a17so9809745lfb.1 for ; Thu, 25 Feb 2021 11:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waldekranz-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=i/27qzdi06B2sG86ad3inSpf+Yw1TpwHO2LBa03+m2U=; b=f9kAhhhh1MmndUQxa/xynNfKskoi+/p4UoXjmV7mqBjU4QmkCF1Aa1g37r/GtXZUs/ MdX/HfHX0bS8K51F5yl1mxe+4rFCJL7f5No+S+FTibWm8/H+BumJ397bl2E82g8QL6QO 6NQKufTt77iiXcuuw3D2ztN+nOJJppMvHaXS3QZcYfRqWUd8xbAQxda0gxJJFcw/QVhU L7OcSIech32+zfj+GAUoYEeXQmJsVNOP9oyfb5PEMWvVTsoB+8xuA9dl0H9NV2cjR4HX Vkr3nGd6J6rhecQB32vNBmsYErPI3js5rKjak4LxBppzNDr3VtWOrbPPW9gv9yBThXY5 PWLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=i/27qzdi06B2sG86ad3inSpf+Yw1TpwHO2LBa03+m2U=; b=io0RBAN0Kz1kBuiLkBpeNAngrmUlKCtSRn8Y/J2IEJj/hR4raE5jLPc3psg7uwqXRQ EZgJJJHcTHARvnx5vDD4Oml0rT7ROkgq+vzntfl9zNLZ5bMlHaSSGFa3P1aNOMTIyEUz /HP1QGI+MAzEXVZU8/79MZraS9ILzTxFCtlqOYpdf9bebWyom/BQ2raI5P8RFjczdhwo eGAWH3hMnjG6u0C3THYUsq5l1f2pFUQIotO4zW6Q0gdExZx8TEy9VZ3AiAxu+bY6SAty 4I4dIG8EMUuZ2c+lfw8K48RF96rhMJxWX8C7A36DP97Ywg+iK54D7DP/Ja0isgrT6ghv ogYA== X-Gm-Message-State: AOAM530AbOrzNieiB0OiuncKBNskFI79M3lV3xMWwjnHPejtVdr6lhVv quLX8HPubo3cIOYbUX09kvrIRw== X-Google-Smtp-Source: ABdhPJwaAVq0A5gWJ1tWlL5/7s+ndMScxw/zwDaROrCdGEFLP3xvsjDKr8VqCfyrF0VBHonQp3Q7FA== X-Received: by 2002:a05:6512:31cc:: with SMTP id j12mr2581806lfe.408.1614281071755; Thu, 25 Feb 2021 11:24:31 -0800 (PST) Received: from wkz-x280 (h-236-82.A259.priv.bahnhof.se. [98.128.236.82]) by smtp.gmail.com with ESMTPSA id k11sm752621ljg.119.2021.02.25.11.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 11:24:31 -0800 (PST) From: Tobias Waldekranz To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vivien Didelot , Kurt Kanzenbach , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , Claudiu Manoil , Alexandre Belloni , George McCollister , DENG Qingfang , Linus Walleij , Hauke Mehrtens , Rasmus Villemoes , Oleksij Rempel Subject: Re: [PATCH net-next 3/4] net: dsa: return -EOPNOTSUPP if .port_lag_join is not implemented In-Reply-To: <20210214155326.1783266-4-olteanv@gmail.com> References: <20210214155326.1783266-1-olteanv@gmail.com> <20210214155326.1783266-4-olteanv@gmail.com> Date: Thu, 25 Feb 2021 20:24:30 +0100 Message-ID: <878s7crlw1.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean wrote: > From: Vladimir Oltean > > There is currently some provisioning for DSA to use the software > fallback for link aggregation, but only if the .port_lag_join is > implemented but it fails (for example because there are more link > aggregation groups than the switch supports, or because the xmit hash > policy cannot be done in hardware, or ...). > > But when .port_lag_join is not implemented at all, the DSA switch > notifier returns zero and software fallback does not kick in. > Change that. > > Signed-off-by: Vladimir Oltean > --- Reviewed-by: Tobias Waldekranz