From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B443AC2D0CD for ; Wed, 18 Dec 2019 11:08:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88A39218AC for ; Wed, 18 Dec 2019 11:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CoJPhPdb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbfLRLIm (ORCPT ); Wed, 18 Dec 2019 06:08:42 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:23013 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726551AbfLRLIm (ORCPT ); Wed, 18 Dec 2019 06:08:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576667321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t9N6bug9fqhjHQqfRWIzS1Bxa22v0COyCASVHwhVdOk=; b=CoJPhPdb6svHWPuOW5RxGA8likt+O2zzms89qF9PtQ0sEk1zkAlO5u9GnsnhGj7DsWEAB2 0OoFRtdU15CssKLCXdS4NQT8Yc23myLlv+E0ixTE/Ix//0lV/H4ObV8+Pjw3QV5zP9f22f E6QOyhkOi/L+w41py2EQE7vtyjyF/YU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-gQztRQRAOQ6SQB4asrSk_Q-1; Wed, 18 Dec 2019 06:08:39 -0500 X-MC-Unique: gQztRQRAOQ6SQB4asrSk_Q-1 Received: by mail-lj1-f199.google.com with SMTP id d14so572343ljg.17 for ; Wed, 18 Dec 2019 03:08:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=t9N6bug9fqhjHQqfRWIzS1Bxa22v0COyCASVHwhVdOk=; b=iRkgBxaBTAi9AIii3i/awErsskAuNM+DvcyVl8tCBCkB/JZO0DhMuuVg0Sz9ZyJtqa fGHd38wnW9UE0bdcZxok8ISY8ZtXDAsE8c8T+DCYYJyhxyEcIDXGPcRgBLP1u7qHi/c9 omfqcu2HYuCJrn5aDJ5EtoTINSAdndgL0jBiiXJIgECWjocFEu1C3yzjhhxa/F7dUzii IIR1fFN5r3Yy0KCj/9ZwTjm//uBMrC6DZoBbaZb98a3rk+1E5FY9noyYxKzbrLK5NFd/ TF/4PiYLmCxkixGluKD3seIushibmF/lrMbefq/gwVLzR+90i5an7JsWJRAuilomQabL /TkQ== X-Gm-Message-State: APjAAAWMSq/FYQ7b/GcC05hJTcRLDayxWZauR5SNdIkikxZLuYIwX5cY 6qNXddC2gJvHYCdWCl9/JcT+K1hSv3k2RLYpUSkf9JohSMXgDNYO7nry29jR2fuWnbE9u8vooIE ikuFxjtEMhPRD2DDW X-Received: by 2002:a2e:9a51:: with SMTP id k17mr1236326ljj.206.1576667317734; Wed, 18 Dec 2019 03:08:37 -0800 (PST) X-Google-Smtp-Source: APXvYqxvL/f+gpRBh2p4/BeptEEvf2ziXJJxLYL3xp5NKCseiQY2pF7SSqzs9T/8bffLHhb2+PPCEw== X-Received: by 2002:a2e:9a51:: with SMTP id k17mr1236295ljj.206.1576667317216; Wed, 18 Dec 2019 03:08:37 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id m15sm951499ljj.16.2019.12.18.03.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 03:08:36 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8A764180969; Wed, 18 Dec 2019 12:08:34 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Naresh Kamboju Cc: Alexei Starovoitov , Daniel Borkmann , Netdev , bpf , Jesper Dangaard Brouer , Yonghong Song , lkft-triage@lists.linaro.org, Leo Yan , Daniel Diaz Subject: Re: [PATCH bpf-next v2] libbpf: Print hint about ulimit when getting permission denied error In-Reply-To: References: <20191216181204.724953-1-toke@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 18 Dec 2019 12:08:34 +0100 Message-ID: <878sn97ux9.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Naresh Kamboju writes: > On Tue, 17 Dec 2019 at 00:00, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c >> index a2cc7313763a..3fe42d6b0c2f 100644 >> --- a/tools/lib/bpf/libbpf.c >> +++ b/tools/lib/bpf/libbpf.c >> @@ -41,6 +41,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -100,6 +101,32 @@ void libbpf_print(enum libbpf_print_level level, co= nst char *format, ...) >> va_end(args); >> } >> >> +static void pr_perm_msg(int err) >> +{ >> + struct rlimit limit; >> + char buf[100]; >> + >> + if (err !=3D -EPERM || geteuid() !=3D 0) >> + return; >> + >> + err =3D getrlimit(RLIMIT_MEMLOCK, &limit); >> + if (err) >> + return; >> + >> + if (limit.rlim_cur =3D=3D RLIM_INFINITY) >> + return; >> + >> + if (limit.rlim_cur < 1024) >> + snprintf(buf, sizeof(buf), "%lu bytes", limit.rlim_cur); > > libbpf.c: In function 'pr_perm_msg': > libbpf.c:120:33: error: format '%lu' expects argument of type 'long > unsigned int', but argument 4 has type 'rlim_t {aka long long unsigned > int}' [-Werror=3Dformat=3D] > snprintf(buf, sizeof(buf), "%lu bytes", limit.rlim_cur); > ~~^ ~~~~~~~~~~~~~~ > %llu > Ah, guess this needs PRIu64. Will send a follow-up, thanks for the report :) -Toke