From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: next-20151126 build: 3 failures 15 warnings (next-20151126) Date: Thu, 26 Nov 2015 20:34:20 +0200 Message-ID: <878u5kmwya.fsf@kamboji.qca.qualcomm.com> References: <20151126121551.GE1929@sirena.org.uk> <87y4dllysz.fsf@kamboji.qca.qualcomm.com> <20151126132228.GG1929@sirena.org.uk> <87lh9kn1dz.fsf@kamboji.qca.qualcomm.com> <20151126170300.GH1929@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , , , , , To: Mark Brown Return-path: In-Reply-To: <20151126170300.GH1929@sirena.org.uk> (Mark Brown's message of "Thu, 26 Nov 2015 17:03:00 +0000") Sender: linux-next-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Mark Brown writes: > On Thu, Nov 26, 2015 at 06:58:32PM +0200, Kalle Valo wrote: >> Mark Brown writes: > >> > No, I didn't make much effort to check though since the use of ifdef was >> > clearly a bug waiting to happen anyway, I was more surprised it worked >> > at all than anything. > >> Michal Marek explains[1] that this is due to commit cf4f21938e13 >> ("kbuild: Allow to specify composite modules with modname-m") and has >> nothing to do with the wireless drivers reorganisation. I'll drop this >> patch as Michal will apply his fix to the kbuild tree. > > It still ought to be fixed regardless of why it showed up - the > intention of the code is that we build the real thermal code regardless > of if that's modular or not but that's not what the code actually does. Like I said above Michal will apply a fix to his tree. Read the full discussion from patchwork: https://patchwork.kernel.org/patch/7707801/ -- Kalle Valo