netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* nonagle flags for TSQ
@ 2014-02-07 15:08 John Ogness
  2014-02-07 15:34 ` Eric Dumazet
  0 siblings, 1 reply; 6+ messages in thread
From: John Ogness @ 2014-02-07 15:08 UTC (permalink / raw)
  To: netdev; +Cc: Eric Dumazet

Hi,

This email is referring to your Linux patch
46d3ceabd8d98ed0ad10f20c595ca784e34786c5.

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=46d3ceabd8d98ed0ad10f20c595ca784e34786c5

I have a question about the use of tcp_write_xmit() in
net/ipv4/tcp_output.c

When tcp_write_xmit() is called, the nonagle flag of the tcp socket is
ignored and instead 0 is passed. This causes the Nagle-algorithm to be
used even if it should not be, which in some cases causes a large delay.

Was there a reason that 0 was hard-coded?

Although current mainline code has been refactored, 0 is still
hard-coded for TSQ cases.

John Ogness

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-02-13  9:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-07 15:08 nonagle flags for TSQ John Ogness
2014-02-07 15:34 ` Eric Dumazet
2014-02-07 15:58   ` Eric Dumazet
2014-02-07 16:34   ` John Ogness
2014-02-07 17:05     ` Eric Dumazet
2014-02-13  9:34       ` John Ogness

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).