From: "Bjørn Mork" <bjorn@mork.no>
To: Ming Lei <ming.lei@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.de>,
Network Development <netdev@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH] USBNET: fix handling padding packet
Date: Wed, 18 Sep 2013 20:33:16 +0200 [thread overview]
Message-ID: <878uyu56ab.fsf@nemi.mork.no> (raw)
In-Reply-To: <CACVXFVNp5Qj-EV+L=FezwFqRnFa7uRFca7Ju9=iTqU+DS1r-fg@mail.gmail.com> (Ming Lei's message of "Thu, 19 Sep 2013 01:03:31 +0800")
Ming Lei <ming.lei@canonical.com> writes:
> On Wed, Sep 18, 2013 at 11:52 PM, Bjørn Mork <bjorn@mork.no> wrote:
>
>> Why don't you test it on the device you tested the SG patch with? I am
>> pretty sure it works just fine using proper ZLP transfer termination.
>
> I should have planned to test it, but didn't know how to build TCP TSO
> to make the whole frame length plus 8 dividable by 1024.
You could test this without enabling TSO and just send IP packets of the
appriopriate size, taking any additional framing into account
Bjørn
next prev parent reply other threads:[~2013-09-18 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 9:10 [PATCH] USBNET: fix handling padding packet Ming Lei
[not found] ` <1379409002-7698-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-09-18 0:33 ` David Miller
2013-09-18 13:46 ` Oliver Neukum
2013-09-18 13:59 ` Bjørn Mork
2013-09-18 15:09 ` Ming Lei
2013-09-18 15:52 ` Bjørn Mork
2013-09-18 16:12 ` David Miller
[not found] ` <87zjra5dpx.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-09-18 17:03 ` Ming Lei
2013-09-18 18:33 ` Bjørn Mork [this message]
2013-09-18 17:06 ` Oliver Neukum
2013-09-18 18:56 ` Bjørn Mork
2013-09-19 6:57 ` Oliver Neukum
[not found] ` <1379573843.8608.7.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2013-09-19 7:18 ` Bjørn Mork
2013-09-19 8:29 ` David Laight
[not found] ` <87wqmd46vj.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-09-19 13:08 ` Ming Lei
[not found] ` <CACVXFVPOyr3eDrJxGhmoxDdZS2FL17qm6jv0ezDECUAk267jFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-11 14:26 ` David Laight
2013-09-18 15:43 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uyu56ab.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).