From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf 2/2] selftests/bpf: Fix up xdp bonding test wrt feature flags
Date: Tue, 05 Mar 2024 16:47:00 +0100 [thread overview]
Message-ID: <87a5ncd6kr.fsf@toke.dk> (raw)
In-Reply-To: <20240305090829.17131-2-daniel@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> writes:
> Adjust the XDP feature flags for the bond device when no bond slave
> devices are attached. After 9b0ed890ac2a ("bonding: do not report
> NETDEV_XDP_ACT_XSK_ZEROCOPY"), the empty bond device must report 0
> as flags instead of NETDEV_XDP_ACT_MASK.
>
> # ./vmtest.sh -- ./test_progs -t xdp_bond
> [...]
> [ 3.983311] bond1 (unregistering): (slave veth1_1): Releasing backup interface
> [ 3.995434] bond1 (unregistering): Released all slaves
> [ 4.022311] bond2: (slave veth2_1): Releasing backup interface
> #507/1 xdp_bonding/xdp_bonding_attach:OK
> #507/2 xdp_bonding/xdp_bonding_nested:OK
> #507/3 xdp_bonding/xdp_bonding_features:OK
> #507/4 xdp_bonding/xdp_bonding_roundrobin:OK
> #507/5 xdp_bonding/xdp_bonding_activebackup:OK
> #507/6 xdp_bonding/xdp_bonding_xor_layer2:OK
> #507/7 xdp_bonding/xdp_bonding_xor_layer23:OK
> #507/8 xdp_bonding/xdp_bonding_xor_layer34:OK
> #507/9 xdp_bonding/xdp_bonding_redirect_multi:OK
> #507 xdp_bonding:OK
> Summary: 1/9 PASSED, 0 SKIPPED, 0 FAILED
> [ 4.185255] bond2 (unregistering): Released all slaves
> [...]
>
> Fixes: 9b0ed890ac2a ("bonding: do not report NETDEV_XDP_ACT_XSK_ZEROCOPY")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2024-03-05 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 9:08 [PATCH bpf 1/2] xdp, bonding: Fix feature flags when there are no slave devs anymore Daniel Borkmann
2024-03-05 9:08 ` [PATCH bpf 2/2] selftests/bpf: Fix up xdp bonding test wrt feature flags Daniel Borkmann
2024-03-05 15:47 ` Toke Høiland-Jørgensen [this message]
2024-03-05 15:46 ` [PATCH bpf 1/2] xdp, bonding: Fix feature flags when there are no slave devs anymore Toke Høiland-Jørgensen
2024-03-06 0:30 ` patchwork-bot+netdevbpf
2024-03-07 13:56 ` Pu Lehui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ncd6kr.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).