From: Petr Machata <petrm@nvidia.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: <netdev@vger.kernel.org>, <kuba@kernel.org>, <pabeni@redhat.com>,
<davem@davemloft.net>, <edumazet@google.com>, <leon@kernel.org>,
<saeedm@nvidia.com>, <moshe@nvidia.com>,
<jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
<tariqt@nvidia.com>, <idosch@nvidia.com>, <petrm@nvidia.com>,
<simon.horman@corigine.com>, <ecree.xilinx@gmail.com>,
<habetsm.xilinx@gmail.com>, <michal.wilczynski@intel.com>,
<jacob.e.keller@intel.com>
Subject: Re: [patch net-next 00/15] devlink: move port ops into separate structure
Date: Wed, 24 May 2023 16:02:48 +0200 [thread overview]
Message-ID: <87a5xt4ye5.fsf@nvidia.com> (raw)
In-Reply-To: <20230524121836.2070879-1-jiri@resnulli.us>
Jiri Pirko <jiri@resnulli.us> writes:
> From: Jiri Pirko <jiri@nvidia.com>
>
> In devlink, some of the objects have separate ops registered alongside
> with the object itself. Port however have ops in devlink_ops structure.
> For drivers what register multiple kinds of ports with different ops
> this is not convenient.
>
> This patchset changes does following changes:
> 1) Introduces devlink_port_ops with functions that allow devlink port
> to be registered passing a pointer to driver port ops. (patch #1)
> 2) Converts drivers to define port_ops and register ports passing the
> ops pointer. (patches #2, #3, #4, #6, #8, and #9)
> 3) Moves ops from devlink_ops struct to devlink_port_ops.
> (patches #5, #7, #10-15)
>
> No functional changes.
The mlxsw bits look good to me. Will take this for a spin in our
regression and report back tomorrow.
prev parent reply other threads:[~2023-05-24 14:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:18 [patch net-next 00/15] devlink: move port ops into separate structure Jiri Pirko
2023-05-24 12:18 ` [patch net-next 01/15] devlink: introduce port ops placeholder Jiri Pirko
2023-05-25 4:48 ` Jakub Kicinski
2023-05-25 6:07 ` Jiri Pirko
2023-05-24 12:18 ` [patch net-next 02/15] ice: register devlink port for PF with ops Jiri Pirko
2023-05-24 17:30 ` Jesse Brandeburg
2023-05-24 12:18 ` [patch net-next 03/15] mlxsw_core: register devlink port " Jiri Pirko
2023-05-25 12:36 ` Petr Machata
2023-05-24 12:18 ` [patch net-next 04/15] nfp: devlink: " Jiri Pirko
2023-05-24 12:18 ` [patch net-next 05/15] devlink: move port_split/unsplit() ops into devlink_port_ops Jiri Pirko
2023-05-24 17:32 ` Jesse Brandeburg
2023-05-25 4:53 ` Jakub Kicinski
2023-05-25 6:05 ` Jiri Pirko
2023-05-25 15:27 ` Jakub Kicinski
2023-05-25 16:53 ` Jiri Pirko
2023-05-25 12:37 ` Petr Machata
2023-05-24 12:18 ` [patch net-next 06/15] mlx4: register devlink port with ops Jiri Pirko
2023-05-24 12:18 ` [patch net-next 07/15] devlink: move port_type_set() op into devlink_port_ops Jiri Pirko
2023-05-24 12:18 ` [patch net-next 08/15] sfc: register devlink port with ops Jiri Pirko
2023-05-24 17:57 ` Alejandro Lucero Palau
2023-05-25 6:10 ` Jiri Pirko
2023-05-25 15:13 ` Alejandro Lucero Palau
2023-05-25 16:52 ` Jiri Pirko
2023-05-24 12:18 ` [patch net-next 09/15] mlx5: register devlink ports " Jiri Pirko
2023-05-24 12:18 ` [patch net-next 10/15] devlink: move port_fn_hw_addr_get/set() to devlink_port_ops Jiri Pirko
2023-05-24 12:18 ` [patch net-next 11/15] devlink: move port_fn_roce_get/set() " Jiri Pirko
2023-05-24 12:18 ` [patch net-next 12/15] devlink: move port_fn_migratable_get/set() " Jiri Pirko
2023-05-24 12:18 ` [patch net-next 13/15] devlink: move port_fn_state_get/set() " Jiri Pirko
2023-05-24 12:18 ` [patch net-next 14/15] devlink: move port_del() " Jiri Pirko
2023-05-24 12:18 ` [patch net-next 15/15] devlink: save devlink_port_ops into a variable in devlink_port_function_validate() Jiri Pirko
2023-05-25 4:55 ` Jakub Kicinski
2023-05-25 5:58 ` Jiri Pirko
2023-05-25 15:29 ` Jakub Kicinski
2023-05-26 8:53 ` Jiri Pirko
2023-05-24 14:02 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5xt4ye5.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).