From: Kurt Kanzenbach <kurt@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH v4 net-next 7/8] hsr: Use a single struct for self_node.
Date: Sat, 26 Nov 2022 10:55:45 +0100 [thread overview]
Message-ID: <87a64edopq.fsf@kurt> (raw)
In-Reply-To: <20221125165610.3802446-8-bigeasy@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Fri Nov 25 2022, Sebastian Andrzej Siewior wrote:
> self_node_db is a list_head with one entry of struct hsr_node. The
> purpose is to hold the two MAC addresses of the node itself.
> It is convenient to recycle the structure. However having a list_head
> and fetching always the first entry is not really optimal.
>
> Created a new data strucure contaning the two MAC addresses named
> hsr_self_node. Access that structure like an RCU protected pointer so
> it can be replaced on the fly without blocking the reader.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Looks better. Thanks.
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-11-26 9:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 16:56 [PATCH v4 net-next 0/8]: hsr: HSR send/recv fixes Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 1/8] Revert "net: hsr: use hlist_head instead of list_head for mac addresses" Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 2/8] hsr: Add a rcu-read lock to hsr_forward_skb() Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 3/8] hsr: Avoid double remove of a node Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 4/8] hsr: Disable netpoll Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 5/8] hsr: Synchronize sending frames to have always incremented outgoing seq nr Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 6/8] hsr: Synchronize sequence number updates Sebastian Andrzej Siewior
2022-11-25 16:56 ` [PATCH v4 net-next 7/8] hsr: Use a single struct for self_node Sebastian Andrzej Siewior
2022-11-26 9:55 ` Kurt Kanzenbach [this message]
2022-11-29 3:25 ` Jakub Kicinski
2022-11-25 16:56 ` [PATCH v4 net-next 8/8] selftests: Add a basic HSR test Sebastian Andrzej Siewior
2022-11-26 9:58 ` Kurt Kanzenbach
2022-11-29 3:24 ` [PATCH v4 net-next 0/8]: hsr: HSR send/recv fixes Jakub Kicinski
2022-11-29 7:21 ` Sebastian Andrzej Siewior
2022-11-29 16:09 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a64edopq.fsf@kurt \
--to=kurt@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).