netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tobias Waldekranz <tobias@waldekranz.com>
To: "Marek Behún" <kabel@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: mv88e6xxx broken on 6176 with "Disentangle STU from VTU"
Date: Fri, 18 Mar 2022 20:20:33 +0100	[thread overview]
Message-ID: <87a6dnjce6.fsf@waldekranz.com> (raw)
In-Reply-To: <20220318182817.5ade8ecd@dellmb>

On Fri, Mar 18, 2022 at 18:28, Marek Behún <kabel@kernel.org> wrote:
> Hello Tobias,
>
> mv88e6xxx fails to probe in net-next on Turris Omnia, bisect leads to
> commit
>   49c98c1dc7d9 ("net: dsa: mv88e6xxx: Disentangle STU from VTU")

Oh wow, really sorry about that! I have it reproduced, and I understand
the issue.

> Trace:
>   mv88e6xxx_setup
>     mv88e6xxx_setup_port
>       mv88e6xxx_port_vlan_join(MV88E6XXX_VID_STANDALONE) OK
>       mv88e6xxx_port_vlan_join(MV88E6XXX_VID_BRIDGED) -EOPNOTSUPP
>

Thanks, that make it easy to find. There is a mismatch between what the
family-info struct says and what the chip-specific ops struct supports.

I'll try to send a fix ASAP.

  reply	other threads:[~2022-03-18 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 17:28 mv88e6xxx broken on 6176 with "Disentangle STU from VTU" Marek Behún
2022-03-18 19:20 ` Tobias Waldekranz [this message]
2022-03-18 20:18   ` Vladimir Oltean
2022-03-18 20:38     ` Tobias Waldekranz
2022-03-18 21:16     ` Tobias Waldekranz
2022-03-18 23:02       ` Vladimir Oltean
2022-03-19  1:15         ` Tobias Waldekranz
2022-03-19  1:27           ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6dnjce6.fsf@waldekranz.com \
    --to=tobias@waldekranz.com \
    --cc=andrew@lunn.ch \
    --cc=kabel@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).