From: Kalle Valo <kvalo@kernel.org>
To: <Ajay.Kathat@microchip.com>
Cc: <davidm@egauge.net>, <Claudiu.Beznea@microchip.com>,
<davem@davemloft.net>, <kuba@kernel.org>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/50] wilc1000: rework tx path to use sk_buffs throughout
Date: Thu, 23 Dec 2021 08:41:30 +0200 [thread overview]
Message-ID: <87a6grx1ph.fsf@kernel.org> (raw)
In-Reply-To: <adce9591-0cf2-f771-25b9-2eebea05f1bc@microchip.com> (Ajay Kathat's message of "Thu, 23 Dec 2021 06:16:17 +0000")
<Ajay.Kathat@microchip.com> writes:
> On 23/12/21 06:44, David Mosberger-Tang wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> OK, so I'm nervous about such a large patch series, but it took a lot
>> of work to break things down into atomic changes. This should be it
>> for the transmit path as far as I'm concerned.
>
>
> Thanks David for the efforts to break down the changes. I am still
> reviewing and testing the previous series and found some inconsistent
> results. I am not sure about the cause of the difference. For some
> tests, the throughput is improved(~1Mbps) but for some CI tests, the
> throughput is less compared(~1Mbps in same range) to the previous.
> Though not observed much difference.
>
> Now the new patches are added to the same series so it is difficult to
> review them in one go.
>
> I have a request, incase there are new patches please include them in
> separate series. Breaking down the patch helps to identify the non
> related changes which can go in separate series. The patches(change) may
> be related to TX path flow but can go in separate series.
Yeah, a thumb of rule is to have around 10-12 patches per patchset. Then
it's still pretty easy to review them and get them accepted. Of course
it's not a hard rule, for smaller patches (like here) having more than
12 is still doable. An also the opposite, with big patches even 10
patches is too much. But 50 patches is just pure pain for the reviewers :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-23 6:41 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 1:14 [PATCH v2 00/50] wilc1000: rework tx path to use sk_buffs throughout David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 01/50] wilc1000: don't hold txq_spinlock while initializing AC queue limits David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 04/50] wilc1000: factor common code in wilc_wlan_cfg_set() and wilc_wlan_cfg_get() David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 08/50] wilc1000: fix management packet type inconsistency David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 19/50] wilc1000: don't tell the chip to go to sleep while copying tx packets David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 09/50] wilc1000: prepare wilc_wlan_tx_packet_done() for sk_buff changes David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 25/50] wilc1000: replace txq_spinlock with ack_filter_lock mutex David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 27/50] wilc1000: simplify ac_balance() a bit David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 17/50] wilc1000: remove no longer used "vif" argument from init_txq_entry() David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 12/50] wilc1000: refactor wilc_wlan_cfg_commit() a bit David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 31/50] wilc1000: eliminate another magic constant David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 16/50] wilc1000: switch tx queue to normal sk_buff entries David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 28/50] wilc1000: improve send_packets() a bit David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 15/50] wilc1000: add struct wilc_skb_tx_cb as an alias of struct txq_entry_t David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 23/50] wilc1000: introduce symbolic names for two tx-related control bits David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 03/50] wilc1000: move receive-queue stats from txq to wilc structure David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 13/50] wilc1000: sanitize config packet sequence number management a bit David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 14/50] wilc1000: if there is no tx packet, don't increment packets-sent counter David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 21/50] wilc1000: declare read-only ac_preserve_ratio as static and const David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 10/50] wilc1000: factor initialization of tx queue-specific packet fields David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 07/50] wilc1000: increment tx_dropped stat counter on tx packet drop David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 20/50] wilc1000: eliminate "max_size_over" variable in fill_vmm_table David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 24/50] wilc1000: protect tx_q_limit with a mutex instead of a spinlock David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 06/50] wilc1000: move tx packet drop code into its own function David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 02/50] wilc1000: switch txq_event from completion to waitqueue David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 22/50] wilc1000: minor syntax cleanup David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 11/50] wilc1000: convert tqx_entries from "int" to "atomic_t" David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 29/50] wilc1000: factor header length calculation into a new function David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 18/50] wilc1000: split huge tx handler into subfunctions David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 37/50] wilc1000: introduce set_header() function David Mosberger-Tang
2021-12-28 15:00 ` kernel test robot
2021-12-23 1:14 ` [PATCH v2 26/50] wilc1000: reduce amount of time ack_filter_lock is held David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 43/50] wilc1000: add support for zero-copy transmit of tx packets David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 45/50] wilc1000: move struct wilc_spi declaration David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 40/50] wilc1000: introduce schedule_packets() function David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 49/50] wilc1000: implement zero-copy transmit support for SPI David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 05/50] wilc1000: add wilc_wlan_tx_packet_done() function David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 39/50] wilc1000: eliminate txq_add_to_head_cs mutex David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 46/50] wilc1000: remove duplicate CRC calculation code David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 30/50] wilc1000: use more descriptive variable names David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 33/50] wilc1000: move ac_desired_ratio calculation to where its needed David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 36/50] wilc1000: introduce transmit path chip queue David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 32/50] wilc1000: introduce vmm_table_entry() helper function David Mosberger-Tang
2021-12-28 12:47 ` kernel test robot
2021-12-23 1:14 ` [PATCH v2 47/50] wilc1000: factor SPI DMA command initialization code into a function David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 44/50] wilc1000: don't allocate tx_buffer when zero-copy is available David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 50/50] wilc1000: add module parameter "disable_zero_copy_tx" to SPI driver David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 48/50] wilc1000: introduce function to find and check DMA response David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 38/50] wilc1000: take advantage of chip queue David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 41/50] wilc1000: use more descriptive variable name David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 34/50] wilc1000: restructure wilc-wlan_handle_txq() for clarity David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 42/50] wilc1000: simplify code by adding header/padding to skb David Mosberger-Tang
2021-12-23 1:14 ` [PATCH v2 35/50] wilc1000: introduce copy_and_send_packets() helper function David Mosberger-Tang
2021-12-23 6:16 ` [PATCH v2 00/50] wilc1000: rework tx path to use sk_buffs throughout Ajay.Kathat
2021-12-23 6:41 ` Kalle Valo [this message]
2021-12-23 15:23 ` David Mosberger-Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6grx1ph.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=davidm@egauge.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).