From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, m-karicheri2@ti.com,
vladimir.oltean@nxp.com, Jose.Abreu@synopsys.com, po.liu@nxp.com,
intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com
Subject: Re: [PATCH net-next v1 6/9] igc: Add support for tuning frame preemption via ethtool
Date: Mon, 07 Dec 2020 14:15:25 -0800 [thread overview]
Message-ID: <87a6up1cw2.fsf@intel.com> (raw)
In-Reply-To: <20201205100030.2e3c5dd2@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Tue, 1 Dec 2020 20:53:22 -0800 Vinicius Costa Gomes wrote:
>> The tc subsystem sets which queues are marked as preemptible, it's the
>> role of ethtool to control more hardware specific parameters. These
>> parameters include:
>>
>> - enabling the frame preemption hardware: As enabling frame
>> preemption may have other requirements before it can be enabled, it's
>> exposed via the ethtool API;
>>
>> - mininum fragment size multiplier: expressed in usually in the form
>> of (1 + N)*64, this number indicates what's the size of the minimum
>> fragment that can be preempted.
>>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>
> WARNING: 'PREEMPTABLE' may be misspelled - perhaps 'PREEMPTIBLE'?
In the datasheet the term PREEMPTABLE is used, and when refering to
register values I chose to be consistent with the datasheet. But as the
margin for confusion is small, I can change to use "preemptible"
everywhere, no problem.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2020-12-07 22:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 4:53 [PATCH net-next v1 0/9] ethtool: Add support for frame preemption Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 1/9] ethtool: Add support for configuring " Vinicius Costa Gomes
2020-12-03 1:53 ` Jakub Kicinski
2020-12-05 17:43 ` Jakub Kicinski
2020-12-07 22:11 ` Vinicius Costa Gomes
2020-12-07 23:21 ` Jakub Kicinski
2020-12-08 0:24 ` Vinicius Costa Gomes
2020-12-08 0:27 ` Vladimir Oltean
2020-12-08 0:48 ` Jakub Kicinski
2020-12-08 6:22 ` Michal Kubecek
2020-12-02 4:53 ` [PATCH net-next v1 2/9] taprio: Add support for frame preemption offload Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 3/9] igc: Set the RX packet buffer size for TSN mode Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 4/9] igc: Only dump registers if configured to dump HW information Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 5/9] igc: Avoid TX Hangs because long cycles Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 6/9] igc: Add support for tuning frame preemption via ethtool Vinicius Costa Gomes
2020-12-05 18:00 ` Jakub Kicinski
2020-12-07 22:15 ` Vinicius Costa Gomes [this message]
2020-12-07 23:22 ` Jakub Kicinski
2020-12-02 4:53 ` [PATCH net-next v1 7/9] igc: Add support for Frame Preemption offload Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 8/9] igc: Add support for exposing frame preemption stats registers Vinicius Costa Gomes
2020-12-05 17:59 ` Jakub Kicinski
2020-12-07 22:29 ` Vinicius Costa Gomes
2020-12-02 4:53 ` [PATCH net-next v1 9/9] igc: Separate TSN configurations that can be updated Vinicius Costa Gomes
2020-12-05 17:50 ` [PATCH net-next v1 0/9] ethtool: Add support for frame preemption Jakub Kicinski
2020-12-07 22:49 ` Vinicius Costa Gomes
2020-12-07 23:12 ` Vladimir Oltean
2020-12-08 0:34 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6up1cw2.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).