From: Petr Machata <pmachata@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Ido Schimmel <idosch@mellanox.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] selftests: forwarding: vxlan_bridge_1d: fix tos value
Date: Thu, 13 Feb 2020 13:52:49 +0100 [thread overview]
Message-ID: <87a75msl7i.fsf@mellanox.com> (raw)
In-Reply-To: <20200213094054.27993-1-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail.com> writes:
> After commit 71130f29979c ("vxlan: fix tos value before xmit") we start
> strict vxlan xmit tos value by RT_TOS(), which limits the tos value less
I don't understand how it is OK to slice the TOS field like this. It
could contain a DSCP value, which will be mangled.
> than 0x1E. With current value 0x40 the test will failed with "v1: Expected
> to capture 10 packets, got 0". So let's choose a smaller tos value for
> testing.
>
> Fixes: d417ecf533fe ("selftests: forwarding: vxlan_bridge_1d: Add a TOS test")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh
> index bb10e33690b2..353613fc1947 100755
> --- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh
> +++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh
> @@ -516,9 +516,9 @@ test_tos()
> RET=0
>
> tc filter add dev v1 egress pref 77 prot ip \
> - flower ip_tos 0x40 action pass
> - vxlan_ping_test $h1 192.0.2.3 "-Q 0x40" v1 egress 77 10
> - vxlan_ping_test $h1 192.0.2.3 "-Q 0x30" v1 egress 77 0
> + flower ip_tos 0x11 action pass
> + vxlan_ping_test $h1 192.0.2.3 "-Q 0x11" v1 egress 77 10
> + vxlan_ping_test $h1 192.0.2.3 "-Q 0x12" v1 egress 77 0
0x11 and 0x12 set the ECN bits, I think it would be better to avoid
that. It works just as well with 0x14 and 0x18.
> tc filter del dev v1 egress pref 77 prot ip
>
> log_test "VXLAN: envelope TOS inheritance"
next prev parent reply other threads:[~2020-02-13 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 9:40 [PATCH net] selftests: forwarding: vxlan_bridge_1d: fix tos value Hangbin Liu
2020-02-13 12:52 ` Petr Machata [this message]
2020-02-14 2:53 ` Hangbin Liu
2020-02-14 10:54 ` Petr Machata
2020-02-17 2:59 ` Hangbin Liu
2020-02-17 10:40 ` Petr Machata
2020-02-18 2:05 ` Hangbin Liu
2020-02-18 3:01 ` David Miller
2020-02-18 8:00 ` Hangbin Liu
2020-02-17 2:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a75msl7i.fsf@mellanox.com \
--to=pmachata@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).