Netdev List
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, tlfalcon@linux.vnet.ibm.com,
	Yuval.Mintz@cavium.com, ariel.elior@cavium.com,
	everest-linux-l2@cavium.com, jay.vosburgh@canonical.com
Subject: Re: [PATCH] bnx2x: drop packets where gso_size is too big for hardware
Date: Fri, 01 Sep 2017 12:42:41 +1000	[thread overview]
Message-ID: <87a82f3zry.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <1504159341.15310.6.camel@edumazet-glaptop3.roam.corp.google.com>

Eric Dumazet <eric.dumazet@gmail.com> writes:

> If you had this test in bnx2x_features_check(), packet could be
> segmented by core networking stack before reaching bnx2x_start_xmit() by
> clearing NETIF_F_GSO_MASK
>
> -> No drop would be involved.

Thanks for the pointer - networking code is all a bit new to me.

I'm just struggling at the moment to figure out what the right way to
calculate the length. My original patch uses gso_size + hlen, but:

 - On reflection, while this solves the immediate bug, I'm not 100% sure
   this is the right thing to be calculating

 - If it is, then we have the problem that hlen is calculated in a bunch
   of weird and wonderful ways which make it a nightmare to extract.

Yuval (or anyone else who groks the driver properly) - what's the right
test to be doing here to make sure we don't write to much data to the
card?

Regards,
Daniel

  reply	other threads:[~2017-09-01  2:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31  5:46 [PATCH] bnx2x: drop packets where gso_size is too big for hardware Daniel Axtens
2017-08-31  6:02 ` Eric Dumazet
2017-09-01  2:42   ` Daniel Axtens [this message]
2017-09-18  4:41   ` Daniel Axtens
2017-09-18 14:42     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a82f3zry.fsf@linkitivity.dja.id.au \
    --to=dja@axtens.net \
    --cc=Yuval.Mintz@cavium.com \
    --cc=ariel.elior@cavium.com \
    --cc=eric.dumazet@gmail.com \
    --cc=everest-linux-l2@cavium.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=netdev@vger.kernel.org \
    --cc=tlfalcon@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox