Re: [PATCH net-next v4 0/6] ethtool: switch EEE netlink interface to use EEE linkmode bitmaps

[Heiner Kallweit <hkallweit1@gmail.com>]

On 29.01.2024 01:10, Andrew Lunn wrote:
> On Sat, Jan 27, 2024 at 02:24:05PM +0100, Heiner Kallweit wrote:
>> So far only 32bit legacy bitmaps are passed to userspace. This makes
>> it impossible to manage EEE linkmodes beyond bit 32, e.g. manage EEE
>> for 2500BaseT and 5000BaseT. This series adds support for passing
>> full linkmode bitmaps between kernel and userspace.
>>
>> Fortunately the netlink-based part of ethtool is quite smart and no
>> changes are needed in ethtool. However this applies to the netlink
>> interface only, the ioctl interface for now remains restricted to
>> legacy bitmaps.
>>
>> Next step will be adding support for the c45 EEE2 standard registers
>> (3.21, 7.62, 7.63) to the genphy_c45 functions dealing with EEE.
>> I have a follow-up series for this ready to be submitted.
> 
> I tend to disagree. The next step should be to work on each driver
> still using supported_32 etc and convert them to use plain supported.
> 
> What i don't want is this conversion left half done. I said i'm happy
> to help convert the remaining drivers, so lets work on that.
> 
Fine with me, EEE2 can wait until this is done.

> My happy to merge this patchset, its a good intermediary step which
> allows each driver to be converted on its own. But i'm likely to NACK
> EEE2 until the _32 are gone.
> 
>      Andrew
Heiner