From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tariq Toukan Subject: Re: [PATCH net] net: rollback orig value on failure of dev_qdisc_change_tx_queue_len Date: Sun, 22 Jul 2018 10:31:12 +0300 Message-ID: <87a8fd21-aa7d-5dae-72ba-ef10dcba23f6@mellanox.com> References: <1532010858-6183-1-git-send-email-tariqt@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , Linux Kernel Network Developers , eranbe@mellanox.com To: Cong Wang , Tariq Toukan Return-path: Received: from mail-eopbgr70083.outbound.protection.outlook.com ([40.107.7.83]:16204 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727869AbeGVI1H (ORCPT ); Sun, 22 Jul 2018 04:27:07 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 19/07/2018 8:25 PM, Cong Wang wrote: > On Thu, Jul 19, 2018 at 7:34 AM Tariq Toukan wrote: >> >> Fix dev_change_tx_queue_len so it rolls back original value >> upon a failure in dev_qdisc_change_tx_queue_len. >> This is already done for notifirers' failures, share the code. >> >> The revert of changes in dev_qdisc_change_tx_queue_len >> in such case is needed but missing (marked as TODO), yet it is >> still better to not apply the new requested value. > > You misunderstand the TODO, that is for reverting tx queue len > change for previous queues in the loop. I still don't have any > nice solution for this yet. > I understood this, but maybe didn't describe it clearly. I'll re-phrase. > Yeah, your change itself looks good. > Thanks. > Please update the changelog. > > Thanks. >