From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Tom Herbert <therbert@google.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] net: Xmit Packet Steering (XPS)
Date: Fri, 20 Nov 2009 21:51:02 +0100 [thread overview]
Message-ID: <87aayg539l.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4B05D8DC.7020907@gmail.com> (Eric Dumazet's message of "Fri, 20 Nov 2009 00:46:36 +0100")
Eric Dumazet <eric.dumazet@gmail.com> writes:
> Here is first version of XPS.
>
> Goal of XPS is to free TX completed skbs by the cpu that submitted the transmit.
>
> Because I chose to union skb->iif with skb->sending_cpu, I chose
> to introduce a new xps_consume_skb(skb), and not generalize consume_skb() itself.
>
> This means that selected drivers must use new function to benefit from XPS
>
> Preliminary tests are quite good, especially on NUMA machines.
>
> Only NAPI drivers can use this new infrastructure (xps_consume_skb() cannot
> be called from hardirq context, only from softirq)
>
> I converted tg3 and pktgen for my tests
Do you have numbers on this? It seems like a lot of effort to avoid transfering
a few cache lines.
-Andi (who is a bit sceptical and would rather see generic work for this in slab)
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-11-20 20:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 23:46 [PATCH net-next-2.6] net: Xmit Packet Steering (XPS) Eric Dumazet
2009-11-20 2:12 ` Changli Gao
2009-11-20 4:58 ` Eric Dumazet
2009-11-20 5:11 ` Changli Gao
2009-11-20 5:24 ` Eric Dumazet
2009-11-20 5:34 ` Changli Gao
2009-11-20 5:42 ` Eric Dumazet
2009-11-20 5:50 ` Changli Gao
[not found] ` <65634d660911191641o4210a797mf1e8168dd8dd8b60@mail.gmail.com>
2009-11-20 5:08 ` Eric Dumazet
2009-11-20 13:32 ` Jarek Poplawski
2009-11-20 14:45 ` Eric Dumazet
2009-11-20 20:04 ` Jarek Poplawski
2009-11-20 21:43 ` Eric Dumazet
2009-11-20 22:08 ` Jarek Poplawski
2009-11-20 22:21 ` Eric Dumazet
2009-11-20 20:51 ` Andi Kleen [this message]
2009-11-20 20:53 ` David Miller
2009-11-20 22:30 ` Eric Dumazet
2009-11-20 22:37 ` Andi Kleen
[not found] ` <65634d660911201642k3930dc78vd576e0e89dc0c794@mail.gmail.com>
2009-11-21 6:58 ` Eric Dumazet
2009-11-20 20:53 ` Jarek Poplawski
2009-11-20 21:35 ` Eric Dumazet
2009-11-20 21:43 ` Joe Perches
2009-11-20 21:49 ` David Miller
2009-11-20 22:01 ` Eric Dumazet
2009-11-20 22:34 ` David Miller
2009-11-20 22:32 ` David Miller
2009-11-20 22:36 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aayg539l.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).