From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [PATCH 2/2] [RFC] Add c/r support for connected INET sockets Date: Thu, 08 Oct 2009 08:41:12 -0700 Message-ID: <87ab01gag7.fsf@caffeine.danplanet.com> References: <1254932945-12578-1-git-send-email-danms@us.ibm.com> <1254932945-12578-3-git-send-email-danms@us.ibm.com> <1255013233.8033.14.camel@Maple> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: John Dykstra Return-path: In-Reply-To: <1255013233.8033.14.camel@Maple> (John Dykstra's message of "Thu\, 08 Oct 2009 14\:47\:13 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org JD> You're passing 0 as the protocol value to sock_create(). This JD> ultimately gets passed to the address family's create() function. The fix is to pass in the previous version of sk_protocol instead of zero, right? It looks like inet_create() has enough intelligence to weed out invalid values for us too... -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org