From: Jason Wang <jasowang@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RESEND PATCH V4 2/2] vDPA/ifcvf: implement doorbell mapping for ifcvf
Date: Wed, 2 Jun 2021 17:06:34 +0800 [thread overview]
Message-ID: <87adb0ea-689e-f014-d81d-37b2ee032c54@redhat.com> (raw)
In-Reply-To: <20210602084550.289599-3-lingshan.zhu@intel.com>
在 2021/6/2 下午4:45, Zhu Lingshan 写道:
> This commit implements doorbell mapping feature for ifcvf.
> This feature maps the notify page to userspace, to eliminate
> vmexit when kick a vq.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/ifcvf/ifcvf_main.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> index ab0ab5cf0f6e..46a992eab3e5 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> @@ -413,6 +413,21 @@ static int ifcvf_vdpa_get_vq_irq(struct vdpa_device *vdpa_dev,
> return vf->vring[qid].irq;
> }
>
> +static struct vdpa_notification_area ifcvf_get_vq_notification(struct vdpa_device *vdpa_dev,
> + u16 idx)
> +{
> + struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev);
> + struct vdpa_notification_area area;
> +
> + area.addr = vf->vring[idx].notify_pa;
> + if (!vf->notify_off_multiplier)
> + area.size = PAGE_SIZE;
> + else
> + area.size = vf->notify_off_multiplier;
> +
> + return area;
> +}
> +
> /*
> * IFCVF currently does't have on-chip IOMMU, so not
> * implemented set_map()/dma_map()/dma_unmap()
> @@ -440,6 +455,7 @@ static const struct vdpa_config_ops ifc_vdpa_ops = {
> .get_config = ifcvf_vdpa_get_config,
> .set_config = ifcvf_vdpa_set_config,
> .set_config_cb = ifcvf_vdpa_set_config_cb,
> + .get_vq_notification = ifcvf_get_vq_notification,
> };
>
> static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
prev parent reply other threads:[~2021-06-02 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 8:45 [RESEND PATCH V4 0/2] vDPA/ifcvf: implement doorbell mapping feature Zhu Lingshan
2021-06-02 8:45 ` [RESEND PATCH V4 1/2] vDPA/ifcvf: record virtio notify base Zhu Lingshan
2021-06-02 8:45 ` [RESEND PATCH V4 2/2] vDPA/ifcvf: implement doorbell mapping for ifcvf Zhu Lingshan
2021-06-02 9:06 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87adb0ea-689e-f014-d81d-37b2ee032c54@redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).