From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE33EC4708F for ; Wed, 2 Jun 2021 09:06:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5A5E60720 for ; Wed, 2 Jun 2021 09:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbhFBJIb (ORCPT ); Wed, 2 Jun 2021 05:08:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41714 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231243AbhFBJI1 (ORCPT ); Wed, 2 Jun 2021 05:08:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622624804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4SKDhNmHqN2aKK0+XSIC4OXwk6NfJlgx4QyzKzOMn5g=; b=LihfZ3YVSxod1cNLQ5LhSyAD3NzgmK/hIsNkws4+8my5qz7rSZthyuvSkzg9o43b8qhvnu UeWbO7/PT5lvH+tczElj7uuSEOZOQULHzMqNG95tSJyufM5j/R/PRhM/wPHEyG35lDcKka aoL0joV2K+fhrj0gTu8oq5xak8rvb6o= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-NbC7gasCOzqlolGTWhT_Sw-1; Wed, 02 Jun 2021 05:06:43 -0400 X-MC-Unique: NbC7gasCOzqlolGTWhT_Sw-1 Received: by mail-pg1-f197.google.com with SMTP id s5-20020a63d0450000b029021cb0aff563so1269641pgi.18 for ; Wed, 02 Jun 2021 02:06:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4SKDhNmHqN2aKK0+XSIC4OXwk6NfJlgx4QyzKzOMn5g=; b=lCz4ywwIdl8CcLUUfCeE0TMZQaKck2vjndVpPDkE1wX/wtqP0HlEeo7CQSsWwi6pHl +5jgtH/eW5nb49ZW4aMDcPkuTfcMpRFYIcdmWlRGkZ0ZoDm24F+K58GmKzSntulrNmNU SH+frjGyusMoO95kaQJ1iLdTZIzj2+jAhyGf0CxJeo6TFMpE4A2Bob8V2SMns6rcLG0g EFi4uf8ueMAwKAhESeLz9oRyohowNZFaB0H7e4K9z1RbGqY4JoFx+skXC1OfrCMbD3Gh 4M9bFCRq4Pu3mGKmqnbupKiLaxSYVZXZKmKcEwpXWnKEm/kxtewp0Bk3DUA8Ud9KBlOY QApQ== X-Gm-Message-State: AOAM531WDuebKblFXnBn6iyHDA33cvuo40GR2xPCLYVfPC+w/8HSd3bC n4AD/1dXrrcLputitS/TNLNQ6Y5T1qGy/J/wg/Ql/ifmDicIhBw7mUfu3+MwmAoDS2VhiAswkSL SVhbQt/jNijZRTjeF X-Received: by 2002:a17:90a:d106:: with SMTP id l6mr29442509pju.164.1622624802290; Wed, 02 Jun 2021 02:06:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywOxQ+NWTfjlQmSNDqckkjmrNWhEkCDBhZCvcjcZYkfXqk+RN3ycPoZAbDZtUF42apd9FTcg== X-Received: by 2002:a17:90a:d106:: with SMTP id l6mr29442495pju.164.1622624802084; Wed, 02 Jun 2021 02:06:42 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id bo14sm249140pjb.40.2021.06.02.02.06.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 02:06:41 -0700 (PDT) Subject: Re: [RESEND PATCH V4 2/2] vDPA/ifcvf: implement doorbell mapping for ifcvf To: Zhu Lingshan , mst@redhat.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org References: <20210602084550.289599-1-lingshan.zhu@intel.com> <20210602084550.289599-3-lingshan.zhu@intel.com> From: Jason Wang Message-ID: <87adb0ea-689e-f014-d81d-37b2ee032c54@redhat.com> Date: Wed, 2 Jun 2021 17:06:34 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210602084550.289599-3-lingshan.zhu@intel.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ÔÚ 2021/6/2 ÏÂÎç4:45, Zhu Lingshan дµÀ: > This commit implements doorbell mapping feature for ifcvf. > This feature maps the notify page to userspace, to eliminate > vmexit when kick a vq. > > Signed-off-by: Zhu Lingshan Acked-by: Jason Wang > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > index ab0ab5cf0f6e..46a992eab3e5 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -413,6 +413,21 @@ static int ifcvf_vdpa_get_vq_irq(struct vdpa_device *vdpa_dev, > return vf->vring[qid].irq; > } > > +static struct vdpa_notification_area ifcvf_get_vq_notification(struct vdpa_device *vdpa_dev, > + u16 idx) > +{ > + struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); > + struct vdpa_notification_area area; > + > + area.addr = vf->vring[idx].notify_pa; > + if (!vf->notify_off_multiplier) > + area.size = PAGE_SIZE; > + else > + area.size = vf->notify_off_multiplier; > + > + return area; > +} > + > /* > * IFCVF currently does't have on-chip IOMMU, so not > * implemented set_map()/dma_map()/dma_unmap() > @@ -440,6 +455,7 @@ static const struct vdpa_config_ops ifc_vdpa_ops = { > .get_config = ifcvf_vdpa_get_config, > .set_config = ifcvf_vdpa_set_config, > .set_config_cb = ifcvf_vdpa_set_config_cb, > + .get_vq_notification = ifcvf_get_vq_notification, > }; > > static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)