Re: [PATCH v3 net-next 08/15] selftests: xsk: split xskxceiver main() into setup, run and cleanup

["Björn Töpel" <bjorn@kernel.org>]

Maciej Fijalkowski <maciej.fijalkowski@intel.com> writes:

> Prepare xskxceiver for running a single endpoint per process by
> untangling main():
>
> - bind_iface() sets up one interface from its -i argument, so that
>   interfaces can get their roles after parsing; -l needs none
> - detect_mode_caps() and detect_ifobj_caps() record DRV, zero-copy and
>   HW ring support as XSK_CAP flags, which mode_supported() checks
> - run_pkt_test() returns the result, which main() counts instead of
>   test->fail, as not every failing path sets it
> - cleanup_iface() restores rings, detaches and unloads one interface
>   and copes with partially initialized objects, as does
>   pkt_stream_delete(NULL), so main() has a single exit path
>
> As the rings of both interfaces now get restored at exit,
> hw_ring_size_reset() skips rings that are already at their defaults,
> as the SIOCETHTOOL path passes such no-op requests on to the driver.
> When the request fails, it keeps the sizes the NIC still has, so that
> a later reset tries again.
>
> Call ksft_print_header(), which also switches stdout to line buffering,
> right after parsing the command line: xskxceiver never called it, so a
> launcher reading through a pipe only saw the output at exit. -l prints
> no TAP header and exits with 0 instead of KSFT_XPASS, as listing the
> tests is not a test result.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Reviewed-by: Björn Töpel <bjorn@kernel.org>