From: Petr Machata <petrm@nvidia.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Petr Machata <petrm@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
David Ahern <dsahern@kernel.org>, <netdev@vger.kernel.org>,
<bridge@lists.linux-foundation.org>,
Andy Roulin <aroulin@nvidia.com>
Subject: Re: [PATCH iproute2-next v2] ip: iplink_bridge: Support fdb_local_vlan_0
Date: Wed, 17 Sep 2025 14:50:43 +0200 [thread overview]
Message-ID: <87bjn9s0nr.fsf@nvidia.com> (raw)
In-Reply-To: <aMqi98APC2YXu5xn@shredder>
Ido Schimmel <idosch@nvidia.com> writes:
> On Tue, Sep 16, 2025 at 06:25:46PM +0200, Petr Machata wrote:
>> @@ -635,6 +648,7 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>>
>> if (tb[IFLA_BR_MULTI_BOOLOPT]) {
>> __u32 mofn_bit = 1 << BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION;
>> + __u32 fdb_vlan_0_bit = 1 << BR_BOOLOPT_FDB_LOCAL_VLAN_0;
>> __u32 mcvl_bit = 1 << BR_BOOLOPT_MCAST_VLAN_SNOOPING;
>> __u32 no_ll_learn_bit = 1 << BR_BOOLOPT_NO_LL_LEARN;
>> __u32 mst_bit = 1 << BR_BOOLOPT_MST_ENABLE;
>> @@ -661,6 +675,11 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>> "mdb_offload_fail_notification",
>> "mdb_offload_fail_notification %u ",
>> !!(bm->optval & mofn_bit));
>> + if (bm->optval & fdb_vlan_0_bit)
>
> Shouldn't this be 'bm->optmask' ?
It should.
prev parent reply other threads:[~2025-09-17 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 16:25 [PATCH iproute2-next v2] ip: iplink_bridge: Support fdb_local_vlan_0 Petr Machata
2025-09-17 12:00 ` Ido Schimmel
2025-09-17 12:50 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjn9s0nr.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=aroulin@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).