From: Thomas Gleixner <tglx@linutronix.de>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: aliceryhl@google.com, andrew@lunn.ch, netdev@vger.kernel.org,
rust-for-linux@vger.kernel.org, hkallweit1@gmail.com,
tmgross@umich.edu, ojeda@kernel.org, alex.gaynor@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@samsung.com
Subject: Re: [PATCH net-next v1 1/2] rust: add delay abstraction
Date: Wed, 02 Oct 2024 21:40:45 +0200 [thread overview]
Message-ID: <87bk02wawy.ffs@tglx> (raw)
In-Reply-To: <CANiq72kf+NrKA14RqA=4pnRhB-=nbUuxOWRg-EXA8oV1KUFWdg@mail.gmail.com>
On Wed, Oct 02 2024 at 16:52, Miguel Ojeda wrote:
> On Wed, Oct 2, 2024 at 4:40 PM FUJITA Tomonori
> <fujita.tomonori@gmail.com> wrote:
>>
>> Sure. Some code use ktime_t to represent duration so using Ktime for
>> the delay functions makes sense. I'll add some methods to Ktime and
>> use it.
>
> We really should still use different types to represent points and
> deltas, even if internally they happen to end up using/being the
> "same" thing.
>
> If we start mixing those two up, then it will be harder to unravel later.
>
> I think Thomas also wanted to have two types, please see this thread:
> https://lore.kernel.org/rust-for-linux/87h6vfnh0f.ffs@tglx/ (we also
> discussed clocks).
Correct. They are distinct.
Btw, why is this sent to netdev and not to LKML? delay is generic code
and has nothing to do with networking.
Thanks,
tglx
next prev parent reply other threads:[~2024-10-02 19:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 11:25 [PATCH net-next v1 0/2] add delay abstraction (sleep functions) FUJITA Tomonori
2024-10-01 11:25 ` [PATCH net-next v1 1/2] rust: add delay abstraction FUJITA Tomonori
2024-10-01 11:33 ` Alice Ryhl
2024-10-01 12:31 ` Andrew Lunn
2024-10-01 15:08 ` Miguel Ojeda
2024-10-02 11:34 ` FUJITA Tomonori
2024-10-02 12:18 ` Andrew Lunn
2024-10-02 12:35 ` Miguel Ojeda
2024-10-02 12:51 ` Andrew Lunn
2024-10-02 13:21 ` Miguel Ojeda
2024-10-02 20:04 ` Thomas Gleixner
2024-10-02 12:37 ` Alice Ryhl
2024-10-02 13:58 ` FUJITA Tomonori
2024-10-02 14:27 ` Alice Ryhl
2024-10-02 14:40 ` FUJITA Tomonori
2024-10-02 14:52 ` Miguel Ojeda
2024-10-02 19:40 ` Thomas Gleixner [this message]
2024-10-03 1:24 ` FUJITA Tomonori
2024-10-03 10:50 ` Miguel Ojeda
2024-10-03 12:33 ` Andrew Lunn
2024-10-04 12:08 ` FUJITA Tomonori
2024-10-04 14:08 ` Andrew Lunn
2024-10-01 11:25 ` [PATCH net-next v1 2/2] net: phy: qt2025: wait until PHY becomes ready FUJITA Tomonori
2024-10-01 11:36 ` Alice Ryhl
2024-10-01 12:48 ` Andrew Lunn
2024-10-02 4:39 ` iopoll abstraction (was: Re: [PATCH net-next v1 2/2] net: phy: qt2025: wait until PHY becomes ready) Dirk Behme
2024-10-02 9:56 ` iopoll abstraction FUJITA Tomonori
2024-10-03 11:52 ` Boqun Feng
2024-10-03 13:45 ` FUJITA Tomonori
2024-10-03 14:25 ` Boqun Feng
2024-10-03 16:00 ` Andrew Lunn
2024-10-04 11:54 ` FUJITA Tomonori
2024-10-03 16:09 ` Andrew Lunn
2024-10-04 11:48 ` FUJITA Tomonori
2024-10-04 13:37 ` Andrew Lunn
2024-10-02 10:13 ` [PATCH net-next v1 2/2] net: phy: qt2025: wait until PHY becomes ready FUJITA Tomonori
2024-10-02 12:31 ` Andrew Lunn
2024-10-03 5:07 ` FUJITA Tomonori
2024-10-02 11:17 ` FUJITA Tomonori
2024-10-01 11:39 ` [PATCH net-next v1 0/2] add delay abstraction (sleep functions) Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk02wawy.ffs@tglx \
--to=tglx@linutronix.de \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).