From: Jakub Sitnicki <jakub@cloudflare.com>
To: Paolo Abeni <pabeni@redhat.com>, Dmitry Antipov <dmantipov@yandex.ru>
Cc: John Fastabend <john.fastabend@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, lvc-project@linuxtesting.org,
syzbot+f363afac6b0ace576f45@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] net: sockmap: avoid race between sock_map_destroy() and sk_psock_put()
Date: Fri, 27 Sep 2024 15:04:02 +0200 [thread overview]
Message-ID: <87bk096yf1.fsf@cloudflare.com> (raw)
In-Reply-To: <80a295b9-8528-4f37-981c-29dc07d3053f@redhat.com> (Paolo Abeni's message of "Tue, 24 Sep 2024 10:23:57 +0200")
On Tue, Sep 24, 2024 at 10:23 AM +02, Paolo Abeni wrote:
> I guess that the main point in Cong's feedback is that a sockmap update is not
> supposed to race with sock_map_destroy() (???) @Cong, @John, @JakubS: any
> comments on that?
Looking into it, but will need a bit more time because I'm working
through a backlog and OoO next week.
@Dmitry,
To start off, could you ask syzbot to give your patch a spin by replying
to its report? See instructions following the report [1].
Thanks,
-jkbs
[1] https://lore.kernel.org/netdev/000000000000abe6b50620a7f370@google.com/
prev parent reply other threads:[~2024-09-27 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 11:43 [PATCH net v2] net: sockmap: avoid race between sock_map_destroy() and sk_psock_put() Dmitry Antipov
2024-09-19 8:51 ` Paolo Abeni
2024-09-19 9:26 ` Dmitry Antipov
2024-09-24 8:23 ` Paolo Abeni
2024-09-25 0:22 ` Michal Luczaj
2024-09-27 13:04 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk096yf1.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=dmantipov@yandex.ru \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+f363afac6b0ace576f45@syzkaller.appspotmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).