From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Kurt Kanzenbach <kurt@linutronix.de>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask
Date: Tue, 28 Nov 2023 15:37:24 -0800 [thread overview]
Message-ID: <87bkbdsb4b.fsf@intel.com> (raw)
In-Reply-To: <20231128074849.16863-1-kurt@linutronix.de>
Kurt Kanzenbach <kurt@linutronix.de> writes:
> Hi,
>
> currently it is possible to configure receive queue assignment using the VLAN
> TCI field with arbitrary masks. However, the hardware only supports steering
> either by full TCI or the priority (PCP) field. In case a wrong mask is given by
> the user the driver will silently convert it into a PCP filter which is not
> desired. Therefore, add a check for it.
>
> Patches #1 to #4 are minor things found along the way.
>
Some very minor things: patches 2,3 and 4 have extra long lines in their
commit messages that checkpatch.pl doesn't seem to like.
Patches 4 and 5 read more like fixes to me. I think they could be
proposed to -net, as they contain fixes to user visible issues. Do you
think that makes sense?
As for the code, feel free to add my Ack to the series:
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
next prev parent reply other threads:[~2023-11-28 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 7:48 [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask Kurt Kanzenbach
2023-11-28 7:48 ` [PATCH net-next 1/5] igc: Use reverse xmas tree Kurt Kanzenbach
2023-11-28 7:48 ` [PATCH net-next 2/5] igc: Use netdev printing functions for flex filters Kurt Kanzenbach
2023-11-28 7:48 ` [PATCH net-next 3/5] igc: Unify filtering rule fields Kurt Kanzenbach
2023-11-28 7:48 ` [PATCH net-next 4/5] igc: Report VLAN EtherType matching back to user Kurt Kanzenbach
2023-11-28 7:48 ` [PATCH net-next 5/5] igc: Check VLAN TCI mask Kurt Kanzenbach
2023-11-28 23:37 ` Vinicius Costa Gomes [this message]
2023-11-29 11:15 ` [PATCH net-next 0/5] igc: ethtool: " Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkbdsb4b.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).