From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C194D51A for ; Mon, 30 Oct 2023 09:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="XT+h0i7N" Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6284ADB for ; Mon, 30 Oct 2023 02:12:28 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-540105dea92so6351986a12.2 for ; Mon, 30 Oct 2023 02:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1698657147; x=1699261947; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=zs9Jp9Umn+28ekdNRcU3k/2uuYw3/HAMrWbbU3oSYBc=; b=XT+h0i7NNsDWUifDgAe9BlHY/37GhEv+a3lbvAZBPL2s73tbeNSSWO2xIzcNCLkOJO +/2R2mZG4loWjXJAYfDUnmopp/1pPqdixqA6fOS2AhRxTDImc+2FEv5fYqqcU3X+4Byb 2vlgWZJjvy0FadHAZCQU/30SA57iLkGaVaqxpmviyTob8864nbImUIdZYZ7SXLMpsxPN 2rmmEzEj9gILM3zuJwQj6Ceks6wb+OUxM7a8u1q282EkZOhuyWSpuzQk7Fc0XDAsx6JQ tad0Ep4Ydk4LbYJvHfzexlFYd84J0Ro0Q9ShVUzhcH9k1kZ6aa/U2A3OvosT5AWvUZwe txrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698657147; x=1699261947; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zs9Jp9Umn+28ekdNRcU3k/2uuYw3/HAMrWbbU3oSYBc=; b=jZULgKDt+gtJLhq7vkezrkdcGp+jv25aHQRqN2RJHweAb68KR8hYYLf9T0iSuSzX1I 7AGzySrccZNmqw1CRTlQ723MmiApzj/4Ibur2D3zhTfZjixPjF6SWpiXBpL5KFhWw+hd Nu3U1gGCL66M6wDbEzB5Q738zyxiJaB9MSwdeDPmZg29KIpU8R8Xbb7maDGkZUxzKeVO Ji6orccWFrplni3i5HOdZYtyUiM9DzYQEhdWjHz+6A4LSwQw9kQ9YdkrMayre9bojqj9 SfSLIr4rBctjVMOBe4/DB01lmggaQf7BQIixJ3q1fYu1yO5F/gmbCxIz+v4EGyyx1rv6 O03Q== X-Gm-Message-State: AOJu0YwNOpyqpS2HerNuIAEkf+dJvfBn/k5l5HXyP4w2efM7Zt06LMTA L730lpeh30MtHtKo18MQkgq61A== X-Google-Smtp-Source: AGHT+IFfQprEGPQ1kTNCsRQhi7/e/RFjn0xIpGcDBtliFbKg3HZxoy1h7ZnFvc7A/zwISzicuGRzSQ== X-Received: by 2002:a50:d5d4:0:b0:53e:98c6:5100 with SMTP id g20-20020a50d5d4000000b0053e98c65100mr7627581edj.30.1698657146943; Mon, 30 Oct 2023 02:12:26 -0700 (PDT) Received: from cloudflare.com (79.184.209.104.ipv4.supernova.orange.pl. [79.184.209.104]) by smtp.gmail.com with ESMTPSA id k10-20020aa7d8ca000000b0053d9f427a6bsm5777732eds.71.2023.10.30.02.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 02:12:26 -0700 (PDT) References: <20231028100552.2444158-1-liujian56@huawei.com> User-agent: mu4e 1.6.10; emacs 28.3 From: Jakub Sitnicki To: Liu Jian Cc: john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect Date: Mon, 30 Oct 2023 10:12:03 +0100 In-reply-to: <20231028100552.2444158-1-liujian56@huawei.com> Message-ID: <87bkcg1nk2.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sat, Oct 28, 2023 at 06:05 PM +08, Liu Jian wrote: > v6->v7: Rebase to latest bpf-next tree, and no changes. > v5->v6: Modified the description of the helper function. > v4->v5: Fix one refcount bug caused by patch1. > v3->v4: Change the two helpers's description. > Let BPF_F_PERMANENT takes precedence over apply/cork_bytes. > > Liu Jian (7): > bpf, sockmap: add BPF_F_PERMANENT flag for skmsg redirect > selftests/bpf: Add txmsg permanently test for sockmap > selftests/bpf: Add txmsg redir permanently test for sockmap > selftests/bpf: add skmsg verdict tests > selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag > selftests/bpf: add tests for verdict skmsg to itself > selftests/bpf: add tests for verdict skmsg to closed socket > > include/linux/skmsg.h | 1 + > include/uapi/linux/bpf.h | 45 +++++-- > net/core/skmsg.c | 6 +- > net/core/sock_map.c | 4 +- > net/ipv4/tcp_bpf.c | 12 +- > tools/include/uapi/linux/bpf.h | 45 +++++-- > .../selftests/bpf/prog_tests/sockmap_basic.c | 122 ++++++++++++++++++ > .../selftests/bpf/progs/test_sockmap_kern.h | 3 +- > .../bpf/progs/test_sockmap_msg_verdict.c | 25 ++++ > tools/testing/selftests/bpf/test_sockmap.c | 41 +++++- > 10 files changed, 272 insertions(+), 32 deletions(-) > create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_msg_verdict.c I gave it one last look. For the series: Reviewed-by: Jakub Sitnicki