From: Jakub Sitnicki <jakub@cloudflare.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
kernel-team@cloudflare.com
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Test tail call counting with bpf2bpf and data on stack
Date: Thu, 16 Jun 2022 17:23:39 +0200 [thread overview]
Message-ID: <87bkusws0j.fsf@cloudflare.com> (raw)
In-Reply-To: <e88f66e7-3bfd-1563-8a74-26f0ac19bfe0@iogearbox.net>
On Thu, Jun 16, 2022 at 04:41 PM +02, Daniel Borkmann wrote:
[...]
> Looks like this fails CI with:
>
> progs/tailcall_bpf2bpf6.c:17:40: error: unknown attribute 'always_unused' ignored [-Werror,-Wunknown-attributes]
> int classifier_0(struct __sk_buff *skb __unused)
> ^~~~~~~~
> progs/tailcall_bpf2bpf6.c:5:33: note: expanded from macro '__unused'
> #define __unused __attribute__((always_unused))
> ^~~~~~~~~~~~~
> 1 error generated.
> make: *** [Makefile:509: /tmp/runner/work/bpf/bpf/tools/testing/selftests/bpf/tailcall_bpf2bpf6.o] Error 1
> make: *** Waiting for unfinished jobs....
> Error: Process completed with exit code 2.
I will switch to __attribute__((unused)) and ignore what checkpatch
says. Will respin. Thanks!
prev parent reply other threads:[~2022-06-16 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 15:17 [PATCH bpf-next 0/2] Fix tail call counting with bpf2bpf Jakub Sitnicki
2022-06-15 15:17 ` [PATCH bpf-next 1/2] bpf, x86: Fix tail call count offset calculation on bpf2bpf call Jakub Sitnicki
2022-06-16 14:45 ` Daniel Borkmann
2022-06-16 15:01 ` Maciej Fijalkowski
2022-06-15 15:17 ` [PATCH bpf-next 2/2] selftests/bpf: Test tail call counting with bpf2bpf and data on stack Jakub Sitnicki
2022-06-16 14:41 ` Daniel Borkmann
2022-06-16 15:23 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkusws0j.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@cloudflare.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).