From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE290C43334 for ; Thu, 16 Jun 2022 15:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377267AbiFPPYd (ORCPT ); Thu, 16 Jun 2022 11:24:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233993AbiFPPYc (ORCPT ); Thu, 16 Jun 2022 11:24:32 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8CB22E09A for ; Thu, 16 Jun 2022 08:24:30 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id b8so2657162edj.11 for ; Thu, 16 Jun 2022 08:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=mwJ8Wif5giUGYYc0iQvQdlGVGAgX9MBCDm879J1dkNc=; b=nJ4wrp4d4giRvsrz2tGN8jwNlWhC5HjRRxJEO/nwdUun42CgqUM6hf2Ud8uDsGHUnk GLFzkD8VJS2sCII3YtD+ojKZNGfCaQitOycarXUiKWk3ptdV+bEkNOAQE1e+C9m7JNFI itDefWllMyMiKUviPAMfYkdLOkGAeg3s5SbcI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=mwJ8Wif5giUGYYc0iQvQdlGVGAgX9MBCDm879J1dkNc=; b=y6Vqu5VoPNy0diUI+kgT80PKd/2TRMGTjaMDxtUhzp34KdYmSTs5kuexc+eSQ2ti9e LwG3609xcgb6cK5Q/J0wz616X1ahac/ABYO4l4MXwGYUDnpG8GjFqSrl4HzbTVFuXyYk GjVeUpipMG4nDIWpbkxkqvi3OpNahWuhaLHuggpcaGz9ODK9h6FujoTsgG9n1sppfsw4 11/MMqWA0mYwVvz+CAec2RcvtcMxqaOT/eHxnC3Z3fF4Mw3oaLdS5g44nnD5hVXJgx+p 0c7XwQnnuOKvFOwsV6MfpNTeVx+Pl7HFORPwEfN2QjXbQygc9YPysrvlLGB8lojWDMKL HrIQ== X-Gm-Message-State: AJIora8Zwm69JAS8J9Uqsaz84ssrgFgO7Vm2rSCCLi7po27oTiTwEZGF i8lj/ZltKUMr7edn4auMLfibpBluzaYEDw== X-Google-Smtp-Source: AGRyM1svNK7krKHYzVECv6ofebO2N8FKcYsnD5iwmDlXTHiG1tYjn/etfFY3EqYSLABQJjMMNBQdTg== X-Received: by 2002:a05:6402:d05:b0:425:b5c8:faeb with SMTP id eb5-20020a0564020d0500b00425b5c8faebmr7090713edb.273.1655393069330; Thu, 16 Jun 2022 08:24:29 -0700 (PDT) Received: from cloudflare.com (79.184.138.130.ipv4.supernova.orange.pl. [79.184.138.130]) by smtp.gmail.com with ESMTPSA id m7-20020aa7c487000000b0042bcf1e0060sm1928928edq.65.2022.06.16.08.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 08:24:29 -0700 (PDT) References: <20220615151721.404596-1-jakub@cloudflare.com> <20220615151721.404596-3-jakub@cloudflare.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Jakub Sitnicki To: Daniel Borkmann Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Maciej Fijalkowski , kernel-team@cloudflare.com Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Test tail call counting with bpf2bpf and data on stack Date: Thu, 16 Jun 2022 17:23:39 +0200 In-reply-to: Message-ID: <87bkusws0j.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 16, 2022 at 04:41 PM +02, Daniel Borkmann wrote: [...] > Looks like this fails CI with: > > progs/tailcall_bpf2bpf6.c:17:40: error: unknown attribute 'always_unused' ignored [-Werror,-Wunknown-attributes] > int classifier_0(struct __sk_buff *skb __unused) > ^~~~~~~~ > progs/tailcall_bpf2bpf6.c:5:33: note: expanded from macro '__unused' > #define __unused __attribute__((always_unused)) > ^~~~~~~~~~~~~ > 1 error generated. > make: *** [Makefile:509: /tmp/runner/work/bpf/bpf/tools/testing/selftests/bpf/tailcall_bpf2bpf6.o] Error 1 > make: *** Waiting for unfinished jobs.... > Error: Process completed with exit code 2. I will switch to __attribute__((unused)) and ignore what checkpatch says. Will respin. Thanks!