From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1540EC433EF for ; Wed, 16 Mar 2022 08:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354673AbiCPIym (ORCPT ); Wed, 16 Mar 2022 04:54:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239454AbiCPIyj (ORCPT ); Wed, 16 Mar 2022 04:54:39 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 131F427CE5 for ; Wed, 16 Mar 2022 01:53:25 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id qa43so2606771ejc.12 for ; Wed, 16 Mar 2022 01:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=NvgUTqVtgWUOFTsgAP3XYX4qyxvUaDUYv7I3OXrHf38=; b=SuilHwMMOP/VEXvbUwxVLSPFD5B9ZpB81dG+xl+srKAfK/bVUDMQwvVkJWbqwcB8gE D4flw6stwL9Hpno2uFmT8+at16t0bhVEGuRv7IsUoVvQ/8YR/xxo8PiVffDkWrE5m1zv iOuipa/DcfH7pUvYYyPr6YY04eWUUsdYNrZBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=NvgUTqVtgWUOFTsgAP3XYX4qyxvUaDUYv7I3OXrHf38=; b=IjkxUP1hfG0/lGx0SiD6LY5mW7ZOQG4fuSqEZH8bDS1yopJVfG9vChZsh7o0glssnu Qy8hkeDsh/VELdfpn81MbMqVelxCGRswypGuOEuIigINrdqdtg/sbsX6HrWvcU42+FvH eDa45vA6vwfhpE31T1mvylubC3MdjFGJqRrDmglc4DCfea8r/yHRpmS64HBvyDSThHRy LKHtJWyoRMTMOhVkzP7V+EK4i+pBL/e+uIPkcwNgQGp1vyXEuBjHzn7s0lQ+LLIIusv/ D7lbg0Xo4V2JAgg4dBy1wW+Mbb61INHhsPH7H0+/QCyysC5YRHwXk81Xuvp4PtHXT0bN evOg== X-Gm-Message-State: AOAM533yF1Bferi2VRuWSp6nsBrmBtxYXkkcFClZGpGm7WnZvbeWBeCP IYHaS0MQ0bqa8AhEXOZbmJkpKQ== X-Google-Smtp-Source: ABdhPJyA6f8csTDLfngXH2GypmC9Y6PgGMvcsN6hh3n5L+FW0iLLhn0iYkd8YDEGY0XX8QmLleZmpw== X-Received: by 2002:a17:906:698a:b0:6ce:b983:babf with SMTP id i10-20020a170906698a00b006ceb983babfmr26173661ejr.553.1647420803560; Wed, 16 Mar 2022 01:53:23 -0700 (PDT) Received: from cloudflare.com ([2a01:110f:4809:d800::f9c]) by smtp.gmail.com with ESMTPSA id ec21-20020a170906b6d500b006d170a3444csm588020ejb.164.2022.03.16.01.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 01:53:23 -0700 (PDT) References: <20220222105156.231344-1-maximmi@nvidia.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Jakub Sitnicki To: Alexei Starovoitov , Maxim Mikityanskiy , Arthur Fabre Cc: "bpf@vger.kernel.org" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "netdev@vger.kernel.org" , Tariq Toukan , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Shuah Khan , Jesper Dangaard Brouer Subject: Re: [PATCH bpf v3] bpf: Support dual-stack sockets in bpf_tcp_check_syncookie Date: Wed, 16 Mar 2022 09:48:52 +0100 In-reply-to: Message-ID: <87bky6xoql.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 15, 2022 at 02:26 PM -07, Alexei Starovoitov wrote: > On Mon, Mar 14, 2022 at 10:49 AM Maxim Mikityanskiy wrote: >> >> > -----Original Message----- >> > From: Alexei Starovoitov >> > >> > On Fri, Mar 11, 2022 at 8:36 AM Maxim Mikityanskiy >> > wrote: >> > > >> > > This patch was submitted more than two weeks ago, and there were no new >> > > comments. Can it be accepted? >> > >> > The patch wasn't acked by anyone. >> > Please solicit reviews for your changes in time. >> >> Could you elaborate? I sent the patch to the mailing list and CCed the >> relevant people. That worked for v1 and v2, I received comments, >> addressed them and sent a v3. What extra steps should I have done to >> "solicit reviews"? What shall I do now? > > cloudflare folks are original authors of this helper and > de-facto owners of this piece of code. > They need to ack it. > So you have to rebase, resubmit and solicit reviews. Thanks for pulling me into the loop. It's just a case of unfortunate timing. Lorenz left Cloudflare end of Feb and he must have missed the email. Adding Arthur to CC, who will be able to help with review and testing once the rebased patch gets resubmitted.