From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F051C433E0 for ; Tue, 26 Jan 2021 08:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B0E020793 for ; Tue, 26 Jan 2021 08:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390562AbhAZIrw (ORCPT ); Tue, 26 Jan 2021 03:47:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55535 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390497AbhAZIqt (ORCPT ); Tue, 26 Jan 2021 03:46:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611650717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9gzTd6btxu4Ytm03Yrm00pwQppiXc/JxoltINtOzavM=; b=Gc48h2lmr1GaI5TUFhT4tDzBuMboPdN+DNHVEds8MMu7CWKNxQqLsL8oQtA5bOWka3a8Ki BCfr/1ltWaSdRRV+bACQIEG0WZJGyKzkkcCjJtyOnZzWcqdsG8hrOlieobc+BUkNS+uDtS WtewN5SYt/eyB82uxFfNIkyBYQmKq7M= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-akntz6Z4OUu8vjEFlRutNg-1; Tue, 26 Jan 2021 03:45:15 -0500 X-MC-Unique: akntz6Z4OUu8vjEFlRutNg-1 Received: by mail-ej1-f72.google.com with SMTP id le12so4701418ejb.13 for ; Tue, 26 Jan 2021 00:45:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=9gzTd6btxu4Ytm03Yrm00pwQppiXc/JxoltINtOzavM=; b=WPntlgAksDHDpcuMwq0N0yOeqKEoMAXNNjkWsMBtL6aIl8USkUpWKAxsBuYqoVikUE FZb06kaMxwrDuxrySzFBnBpvP2y939t9IvhXn7asFF5MOHjAyuKDAbUHfU98Lxiar1Gg CG9d8G2qnxeb0WhqO8wHgvFJQIPxTNgyLK9rqhxlcV+1HXdaB74jizAuHBwKmcgTNmZz A1czaJaWY7iDiB2SZZLJT8pNjhQCbsA8ItYiCNrlfFBscPZ1MCwB4Z62iJ53OYqHY63p SsXTx1MBxN/wdwIWaOuwg/LZ5uwCOjtt+jFN4cgqVjOWM96s9sEzODVRX04aB+i5ER8W Vtcw== X-Gm-Message-State: AOAM533Ml6+Pre5wcz8S1FBCctmLDyiv3Q4t78SYBx5FXkDs3QTXwfyC FIyT6xc98Qg7zKmW2r1uiYG2QAlk03yJDTP/FI4aUgFhg6h3Oj3CtBJKGe0LWmf5IOVjU8Vr7rF WfB0TL+CMFkGEtPy5 X-Received: by 2002:a17:906:3a13:: with SMTP id z19mr2929234eje.317.1611650714305; Tue, 26 Jan 2021 00:45:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJx03Mfbqu1LpR8FbZ3JbEqBq8v6YQIBFfG+PF3Y7BTCckd7Z8SXCcUKEb/nMVNSKlNABdcH4w== X-Received: by 2002:a17:906:3a13:: with SMTP id z19mr2929218eje.317.1611650713949; Tue, 26 Jan 2021 00:45:13 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id y8sm11850387edd.97.2021.01.26.00.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 00:45:13 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id A46B4180349; Tue, 26 Jan 2021 09:45:11 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Ciara Loftus , netdev@vger.kernel.org, bpf@vger.kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, weqaar.a.janjua@intel.com Cc: Ciara Loftus , Neil Horman Subject: Re: [PATCH bpf-next v2 0/6] AF_XDP Packet Drop Tracing In-Reply-To: <20210126075239.25378-1-ciara.loftus@intel.com> References: <20210126075239.25378-1-ciara.loftus@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 26 Jan 2021 09:45:11 +0100 Message-ID: <87bldccciw.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Ciara Loftus writes: > This series introduces tracing infrastructure for AF_XDP sockets (xsks). > A trace event 'xsk_packet_drop' is created which can be enabled by toggling > > /sys/kernel/debug/tracing/events/xsk/xsk_packet_drop/enable > > When enabled and packets are dropped in the kernel, traces are generated > which describe the reason for the packet drop as well as the netdev and > qid information of the xsk which encountered the drop. > > Example traces: > > 507.588563: xsk_packet_drop: netdev: eth0 qid 0 reason: rxq full > 507.588567: xsk_packet_drop: netdev: eth0 qid 0 reason: packet too big > 507.588568: xsk_packet_drop: netdev: eth0 qid 0 reason: fq empty > > The event can also be monitored using perf: > > perf stat -a -e xsk:xsk_packet_drop Would it make sense to also hook this up to drop_monitor? -Toke