From: Leon Schuermann <leon@is.currently.online>
To: Jakub Kicinski <kuba@kernel.org>
Cc: oliver@neukum.org, davem@davemloft.net, hayeswang@realtek.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub
Date: Sat, 09 Jan 2021 10:39:27 +0100 [thread overview]
Message-ID: <87bldye9f4.fsf@is.currently.online> (raw)
In-Reply-To: <20210108182030.77839d11@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 8 Jan 2021 21:27:27 +0100 Leon Schuermann wrote:
>> This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to
>> work with the cdc_ether driver.
>
> When you say "used to work" do you mean there was a regression where
> the older kernels would work fine and newer don't? Or just "it works
> most of the time"?
Sorry, I should've clarified that. "Used to work" is supposed to say
"the device used the generic cdc_ether driver", as in
[ +0.000004] usb 4-1.1: Product: Lenovo Powered Hub
[ +0.000003] usb 4-1.1: Manufacturer: Lenovo
[ +0.000002] usb 4-1.1: SerialNumber: xxxxxxxxx
[ +0.024803] cdc_ether 4-1.1:2.0 eth0: register 'cdc_ether' at
usb-0000:2f:00.0-1.1, CDC Ethernet Device,
xx:xx:xx:xx:xx:xx
I guess it did technically work correctly, except for the reported issue
when the host system suspends, which is fixed by using the dedicated
Realtek driver. As far as I know this hasn't been fixed before, so it's
not a regression.
Should I update the commit message accordingly? Thanks!
Leon
next prev parent reply other threads:[~2021-01-09 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 20:27 [PATCH 0/1] r8152: Add Lenovo Powered USB-C Travel Hub Leon Schuermann
2021-01-08 20:27 ` [PATCH 1/1] " Leon Schuermann
2021-01-09 2:20 ` Jakub Kicinski
2021-01-09 9:39 ` Leon Schuermann [this message]
2021-01-09 22:43 ` Jakub Kicinski
2021-01-11 19:03 ` Leon Schuermann
2021-01-11 19:03 ` [PATCH 1/2] " Leon Schuermann
2021-01-13 4:10 ` patchwork-bot+netdevbpf
2021-01-11 19:03 ` [PATCH 2/2] r8153_ecm: Add Lenovo Powered USB-C Hub as a fallback of r8152 Leon Schuermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bldye9f4.fsf@is.currently.online \
--to=leon@is.currently.online \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).