From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, sassmann@redhat.com
Subject: Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-11-10
Date: Thu, 12 Nov 2020 11:55:24 -0800 [thread overview]
Message-ID: <87blg28i4z.fsf@intel.com> (raw)
In-Reply-To: <20201112085533.0d8c55d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
>
> Pulled, thanks!
>
> Please double check the use of the spin lock in patch 3. Stats are
> updated in an atomic context when read from /proc, you probably need
> to convert that spin lock to _bh.
I just did some tests with lockdep enabled, reading from /proc/net/dev
in a loop, and everything seems fine. Am I missing something?
Cheers,
--
Vinicius
next prev parent reply other threads:[~2020-11-12 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 0:19 [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-11-10 Tony Nguyen
2020-11-11 0:19 ` [net 1/4] i40e: Fix MAC address setting for a VF via Host/VM Tony Nguyen
2020-11-11 0:19 ` [net 2/4] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc() Tony Nguyen
2020-11-11 0:19 ` [net 3/4] igc: Fix returning wrong statistics Tony Nguyen
2020-11-11 0:19 ` [net 4/4] MAINTAINERS: Update repositories for Intel Ethernet Drivers Tony Nguyen
2020-11-12 16:55 ` [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-11-10 Jakub Kicinski
2020-11-12 19:18 ` Nguyen, Anthony L
2020-11-12 19:55 ` Vinicius Costa Gomes [this message]
2020-11-12 20:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blg28i4z.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox