From: Thomas Gleixner <tglx@linutronix.de>
To: Hillf Danton <hdanton@sina.com>, Johannes Berg <johannes.berg@intel.com>
Cc: syzbot <syzbot+ca740b95a16399ceb9a5@syzkaller.appspotmail.com>,
davem@davemloft.net, hchunhui@mail.ustc.edu.cn, ja@ssi.bg,
jmorris@namei.org, kuznet@ms2.inr.ac.ru,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com, yoshfuji@linux-ipv6.org,
Hillf Danton <hdanton@sina.com>
Subject: Re: [PATCH] mac80211_hwsim: close the race between running and enqueuing hrtimer
Date: Tue, 29 Sep 2020 21:28:56 +0200 [thread overview]
Message-ID: <87blhojsav.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200929085749.12396-1-hdanton@sina.com>
On Tue, Sep 29 2020 at 16:57, Hillf Danton wrote:
> So the timer was armed at some point and then the expiry which does the
> forward races with the ioctl which starts the timer. Lack of
> serialization or such ...
> ===
>
> To close the race, replace hrtimer_is_queued() with hrtimer_active() on
> enqueuing timer, because it also covers the case of a running timer in
> addition to the queued one.
>
> Link: https://lore.kernel.org/lkml/87pn65khft.fsf@nanos.tec.linutronix.de/
> Reported-by: syzbot+ca740b95a16399ceb9a5@syzkaller.appspotmail.com
> Decoded-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Hillf Danton <hdanton@sina.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
parent reply other threads:[~2020-09-29 19:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200929085749.12396-1-hdanton@sina.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blhojsav.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=davem@davemloft.net \
--cc=hchunhui@mail.ustc.edu.cn \
--cc=hdanton@sina.com \
--cc=ja@ssi.bg \
--cc=jmorris@namei.org \
--cc=johannes.berg@intel.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+ca740b95a16399ceb9a5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).