From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Joergen Andreasen <joergen.andreasen@microchip.com>
Cc: Andre Guedes <andre.guedes@intel.com>,
intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, vladimir.oltean@nxp.com, po.liu@nxp.com,
m-karicheri2@ti.com, Jose.Abreu@synopsys.com
Subject: Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption
Date: Wed, 20 May 2020 14:32:31 -0700 [thread overview]
Message-ID: <87blmimgwg.fsf@intel.com> (raw)
In-Reply-To: <20200520125232.s3zrmlnesqjilcf6@soft-dev16>
Joergen Andreasen <joergen.andreasen@microchip.com> writes:
>> So I thought I was better to let the driver decide what values are
>> acceptable.
>>
>> This is a good question for people working with other hardware.
>>
>
> I think it's most intuitive to use the values for AddFragSize as described in
> 802.3br (N = 0, 1, 2, 3).
> You will anyway have to use one of these values when you want to expose the
> requirements of your receiver through LLDP.
>
Thanks. Seems that keeping this value restricted to multiples of 64 is
the way to go. Will fix for the next version of the series.
Cheers,
--
Vinicius
prev parent reply other threads:[~2020-05-20 21:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 1:29 [next-queue RFC 0/4] ethtool: Add support for frame preemption Vinicius Costa Gomes
2020-05-16 1:29 ` [next-queue RFC 1/4] ethtool: Add support for configuring " Vinicius Costa Gomes
2020-05-19 15:27 ` Murali Karicheri
2020-05-16 1:29 ` [next-queue RFC 2/4] ethtool: Add support for configuring frame preemption via netlink Vinicius Costa Gomes
2020-05-16 1:29 ` [next-queue RFC 3/4] igc: Add support for configuring frame preemption Vinicius Costa Gomes
2020-05-19 16:36 ` Murali Karicheri
2020-05-16 1:29 ` [next-queue RFC 4/4] igc: Add support for exposing frame preemption stats registers Vinicius Costa Gomes
2020-05-20 12:50 ` Murali Karicheri
2020-05-16 9:33 ` [next-queue RFC 0/4] ethtool: Add support for frame preemption Michal Kubecek
2020-05-18 19:34 ` Vinicius Costa Gomes
2020-05-19 22:40 ` Andre Guedes
2020-05-19 22:53 ` Vinicius Costa Gomes
2020-05-16 20:37 ` David Miller
2020-05-16 21:03 ` Vladimir Oltean
2020-05-16 22:19 ` David Miller
2020-05-17 10:51 ` Vladimir Oltean
2020-05-17 18:45 ` Andrew Lunn
2020-05-17 19:04 ` Vladimir Oltean
2020-05-18 19:05 ` Vinicius Costa Gomes
2020-05-18 20:56 ` Jakub Kicinski
2020-05-18 22:06 ` Vinicius Costa Gomes
2020-05-18 22:22 ` Jakub Kicinski
2020-05-18 23:05 ` Vinicius Costa Gomes
2020-05-18 23:09 ` Jakub Kicinski
2020-05-20 21:42 ` [Intel-wired-lan] " Andre Guedes
2020-05-20 22:35 ` Vinicius Costa Gomes
2020-05-19 16:34 ` Murali Karicheri
2020-05-19 17:49 ` Vinicius Costa Gomes
2020-05-17 15:06 ` Michael Walle
2020-05-18 13:36 ` Murali Karicheri
2020-05-19 20:41 ` Michael Walle
2020-05-19 14:53 ` Murali Karicheri
2020-05-19 15:32 ` Vinicius Costa Gomes
2020-05-19 16:11 ` Murali Karicheri
2020-05-19 22:39 ` Andre Guedes
2020-05-19 23:37 ` Vinicius Costa Gomes
2020-05-20 12:47 ` Murali Karicheri
2020-05-20 12:52 ` Joergen Andreasen
2020-05-20 21:32 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blmimgwg.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=andre.guedes@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joergen.andreasen@microchip.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).