netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Joe Perches <joe@perches.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Daniel Drake <dsd@gentoo.org>,
	Ulrich Kunitz <kune@deine-taler.de>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] zd1211rw/zd_usb.h: Replace zero-length array with flexible-array member
Date: Thu, 05 Mar 2020 18:10:10 +0200	[thread overview]
Message-ID: <87blpapyu5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <256881484c5db07e47c611a56550642a6f6bd8e9.camel@perches.com> (Joe Perches's message of "Thu, 05 Mar 2020 07:20:04 -0800")

Joe Perches <joe@perches.com> writes:

> On Thu, 2020-03-05 at 16:50 +0200, Kalle Valo wrote:
>> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> []
>> >  drivers/net/wireless/zydas/zd1211rw/zd_usb.h | 8 ++++----
>> >  1 file changed, 4 insertions(+), 4 deletions(-)
>> 
>> "zd1211rw: " is enough, no need to have the filename in the title.

>> But I asked this already in an earlier patch, who prefers this format?
>> It already got opposition so I'm not sure what to do.
>
> I think it doesn't matter.
>
> Trivial inconsistencies in patch subject and word choice
> don't have much overall impact.

I wrote in a confusing way, my question above was about the actual patch
and not the the title. For example, Jes didn't like this style change:

https://patchwork.kernel.org/patch/11402315/

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-03-05 16:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 11:12 [PATCH][next] zd1211rw/zd_usb.h: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-03-05 14:50 ` Kalle Valo
2020-03-05 15:20   ` Joe Perches
2020-03-05 16:10     ` Kalle Valo [this message]
2020-03-05 18:28       ` Gustavo A. R. Silva
2020-03-10 13:56         ` Kalle Valo
2020-03-10 21:52           ` Gustavo A. R. Silva
2020-03-10 22:07             ` Jes Sorensen
2020-03-10 22:13               ` Gustavo A. R. Silva
2020-03-10 22:15                 ` Joe Perches
2020-03-10 22:21                   ` Gustavo A. R. Silva
2020-03-10 22:28                     ` Joe Perches
2020-03-10 22:33                       ` Jes Sorensen
2020-03-10 22:41                         ` Joe Perches
2020-03-10 22:46                           ` Gustavo A. R. Silva
2020-03-10 22:33                       ` Gustavo A. R. Silva
2020-03-10 22:20                 ` Jes Sorensen
2020-03-10 22:31                   ` Gustavo A. R. Silva
2020-03-10 22:34                     ` Jes Sorensen
2020-03-10 22:36                       ` Gustavo A. R. Silva
2020-03-23 16:46                         ` Kalle Valo
2020-03-23 17:14 ` [PATCH][next] zd1211rw: " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blpapyu5.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=dsd@gentoo.org \
    --cc=gustavo@embeddedor.com \
    --cc=joe@perches.com \
    --cc=kune@deine-taler.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).