From: "Bjørn Mork" <bjorn@mork.no>
To: Oliver Neukum <oliver@neukum.org>
Cc: Enrico Mioso <mrkiko.rs@gmail.com>,
Christian Panton <christian@panton.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices
Date: Tue, 11 Jul 2017 23:14:48 +0200 [thread overview]
Message-ID: <87bmoqad6f.fsf@miraculix.mork.no> (raw)
In-Reply-To: <1499806256.29772.1.camel@neukum.org> (Oliver Neukum's message of "Tue, 11 Jul 2017 22:50:56 +0200")
Oliver Neukum <oliver@neukum.org> writes:
> Am Dienstag, den 11.07.2017, 17:21 +0200 schrieb Enrico Mioso:
>> Some firmwares in Huawei E3372H devices have been observed to switch back
>> to NTB 32-bit format after altsetting switch.
>> This patch implements a driver flag to check for the device settings and
>> set NTB format to 16-bit again if needed.
>> The flag has been activated for devices controlled by the huawei_cdc_ncm.c
>> driver.
>
> Hi,
>
> does this cover reset_resume()?
AFAIK reset_resume doesn't really work for 3G/LTE modems. Too much
state to restore both in firmware and network, with no well defined
protocol to restore it.
The only reason for having reset_resume in the modem drivers is that
quite a few modems have an SD reader. We need to support persist for the
usb-storage function, even if the modem functions fail. There is no
reason to mess up the file system too.
Bjørn
next prev parent reply other threads:[~2017-07-11 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 15:21 [PATCH V3] Set NTB format again after altsetting switch for Huawei devices Enrico Mioso
2017-07-11 21:04 ` Oliver Neukum
[not found] ` <1499806256.29772.1.camel@neukum.org>
2017-07-11 21:14 ` Bjørn Mork [this message]
2017-07-14 15:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmoqad6f.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=christian@panton.org \
--cc=linux-usb@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).