From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: nico@fluxnic.net, davem@davemloft.net, mugunthanvnm@ti.com,
jarod@redhat.com, felipe.balbi@linux.intel.com,
rmk+kernel@armlinux.org.uk, fw@strlen.de, jeremy.linton@arm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings
Date: Sun, 05 Mar 2017 14:47:00 +0100 [thread overview]
Message-ID: <87bmtfx2cr.fsf@belgarion.home> (raw)
In-Reply-To: <1488627759-8717-1-git-send-email-tremyfr@gmail.com> (Philippe Reynes's message of "Sat, 4 Mar 2017 12:42:39 +0100")
Philippe Reynes <tremyfr@gmail.com> writes:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> Changelog:
> v2:
> - also update comment (feeback from Russel King)
Ok, I tested it, with :
ethtool -s eth0 duplex half autoneg off speed 10
ethtool eth0
=> see the changes
ping -f x.x.x.x
ethtool -s eth0 duplex full autoneg on
ethtool eth0
=> see the changes
ping -f x.x.x.x
This both with your patch and without, it works in both cases, and the former as
a smaller throughput, which makes me believe the patch is fine.
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
next prev parent reply other threads:[~2017-03-05 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 11:42 [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings Philippe Reynes
2017-03-05 13:47 ` Robert Jarzmik [this message]
2017-03-09 6:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmtfx2cr.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=davem@davemloft.net \
--cc=felipe.balbi@linux.intel.com \
--cc=fw@strlen.de \
--cc=jarod@redhat.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).