From mboxrd@z Thu Jan 1 00:00:00 1970 From: Atzm Watanabe Subject: Re: [PATCH v4 3/3] packet: deliver VLAN TPID to userspace Date: Tue, 17 Dec 2013 23:28:24 +0900 Message-ID: <87bo0f7drr.wl%atzm@stratosphere.co.jp> References: <87d2kv7fdn.wl%atzm@stratosphere.co.jp> <52B05B61.9020200@redhat.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org, Stephen Hemminger , Ben Hutchings , David Miller , David Laight To: Daniel Borkmann Return-path: Received: from mail-qe0-f45.google.com ([209.85.128.45]:42015 "EHLO mail-qe0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752726Ab3LQO2Y (ORCPT ); Tue, 17 Dec 2013 09:28:24 -0500 Received: by mail-qe0-f45.google.com with SMTP id 6so5233249qea.18 for ; Tue, 17 Dec 2013 06:28:24 -0800 (PST) In-Reply-To: <52B05B61.9020200@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: At Tue, 17 Dec 2013 15:10:41 +0100, Daniel Borkmann wrote: > > On 12/17/2013 02:53 PM, Atzm Watanabe wrote: > > This enables userspace to get VLAN TPID as well as the VLAN TCI. > > > > Signed-off-by: Atzm Watanabe > > Acked-by: Daniel Borkmann > > Looks good, imho. > > Maybe, later on in a follow-up you could also update > Documentation/networking/packet_mmap.txt in places > related to vlan bits, so that people are aware of this. Thank you for the quick reviewing and pointing. Yes, I'll send a patch that updates documentation later.